Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multi urls matching. #125

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Conversation

IRONICBo
Copy link
Collaborator

馃攳 What type of PR is this?

/kind feature

馃憖 What this PR does / why we need it:

Support multi url hook matching.

馃叞 Which issue(s) this PR fixes:

Fixes #124

Signed-off-by: IRONICBo <47499836+IRONICBo@users.noreply.github.com>
Signed-off-by: IRONICBo <47499836+IRONICBo@users.noreply.github.com>
@IRONICBo IRONICBo temporarily deployed to openkf July 19, 2023 10:01 — with GitHub Actions Inactive
@IRONICBo IRONICBo temporarily deployed to openkf July 19, 2023 10:02 — with GitHub Actions Inactive
cubxxw
cubxxw previously approved these changes Jul 19, 2023
server/internal/middleware/hooks/gen_cros_hook.go Outdated Show resolved Hide resolved
server/internal/middleware/hooks/gen_cros_hook.go Outdated Show resolved Hide resolved
server/internal/middleware/hooks/gen_cros_hook.go Outdated Show resolved Hide resolved
@cubxxw cubxxw disabled auto-merge July 19, 2023 10:33
Copy link
Contributor

@PolarishT PolarishT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please to solve those probs above

Signed-off-by: IRONICBo <47499836+IRONICBo@users.noreply.github.com>
@IRONICBo IRONICBo temporarily deployed to openkf July 19, 2023 11:05 — with GitHub Actions Inactive
@IRONICBo IRONICBo enabled auto-merge July 19, 2023 11:05
@IRONICBo IRONICBo temporarily deployed to openkf July 19, 2023 11:05 — with GitHub Actions Inactive
@IRONICBo IRONICBo self-assigned this Jul 19, 2023
@IRONICBo IRONICBo added this pull request to the merge queue Jul 19, 2023
Merged via the queue into openimsdk:main with commit 4b053e4 Jul 19, 2023
7 checks passed
@IRONICBo IRONICBo deleted the feat/feat-124 branch July 19, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enhance hook matching.
4 participants