Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workflow to delete app group #61

Merged
merged 6 commits into from
Oct 12, 2021
Merged

add workflow to delete app group #61

merged 6 commits into from
Oct 12, 2021

Conversation

robertchoi80
Copy link
Contributor

@robertchoi80 robertchoi80 mentioned this pull request Oct 6, 2021
Closed
zugwan
zugwan requested changes Oct 7, 2021
View reviewed changes
templates/argo-cd/deleteproject-wftpl.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Oct 11, 2021
@robertchoi80
divide app deletion into two phases:
b394840 
normal apps and operators
@ktkfree
Copy link
Contributor

ktkfree commented Oct 12, 2021

공용으로 잘 만들어 주셨습니다.
tks-cluster 삭제시에는 filter 를 조정하면서 호출하면 될 것 같네요.
main merge 후 테스트 클러스터 지워보면서 테스트해보겠습니다.

@ktkfree ktkfree merged commit 8a76e58 into openinfradev:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugwan zugwan zugwan approved these changes

@ktkfree ktkfree ktkfree approved these changes

@Jaesang Jaesang Awaiting requested review from Jaesang

Assignees
No one assigned
Labels
Stale There has been no activity on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertchoi80 @ktkfree @zugwan