move eck and kibana installation to servicemesh and fix to delete-apps #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move eck and kibana to servicemesh
seungkyua
force-pushed
the
20220328_install_eck_kibana
branch
from
e9120c1
to
19e3ecf
Compare
robertchoi80
approved these changes
Mar 28, 2022
ktkfree
reviewed
Mar 28, 2022
| [ | ||
| { "app_group": "lma", "path": "eck-resource", "namespace": "lma", "target_cluster": "" }, | ||
| { "app_group": "lma", "path": "fluentbit", "namespace": "lma", "target_cluster": "" }, | ||
| { "app_group": "lma", "path": "kubernetes-event-exporter", "namespace": "lma", "target_cluster": "" } | ||
| ] |
There was a problem hiding this comment.
- service mesh 에서 lma appgroup,namespace 를 사용하는데... 의도된건가요?
- 이동이면, 기존의 lma 설치 workflow 에서도 제거되야 하지 않을까요?
There was a problem hiding this comment.
- service mesh 에서 lma appgroup,namespace 를 사용하는데... 의도된건가요?
- 이동이면, 기존의 lma 설치 workflow 에서도 제거되야 하지 않을까요?
- 의도된 것입니다. app_group 이 path 를 보기 때문에 lma 디렉토리를 봐야 합니다.
- 일단 lma 에서 lma_efk 를 설치 안하면 되기 때문에 service mesh 에 설치를 추가했습니다. servicemesh 에서 설치가 가능해지면 추후 lma-efk 에서 제거하는 단계적 접근 방식입니다.
There was a problem hiding this comment.
lma 와 servicemesh 의 dependecy 가 없을 수록 좋을 것 같습니다. (가능하다면)
appgroup, namespace 등은 추후 고민해보면 좋겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move eck and kibana to servicemesh
fix delete-apps when using grep