Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PH for Jersey #397

Open
Lee-Carre opened this issue Jun 8, 2021 · 7 comments · May be fixed by #424
Open

PH for Jersey #397

Lee-Carre opened this issue Jun 8, 2021 · 7 comments · May be fixed by #424
Assignees
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation. type: feature Introduction of new functionality.

Comments

@Lee-Carre
Copy link

An error occurred during evaluation of the value "PH". Please submit a pull request: https://github.com/opening-hours/opening_hours.js. 
There are no holidays (PH) defined for country je.

Perma-link.

Public holidays for Jersey can be extracted from Bank Holiday Dates.

@ypid
Copy link
Member

ypid commented Jun 8, 2021

I updated my policy how to handle such issues https://github.com/opening-hours/opening_hours.js#holidays

Short, thank you but I cannot take the time to add the holidays myself. But you are welcome to work on it and I will take the time to integrate/merge your work.

@ypid ypid added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation. type: feature Introduction of new functionality. labels Jun 8, 2021
@ypid ypid closed this as completed Nov 6, 2021
@Lee-Carre
Copy link
Author

Why closed when unresolved?

@ypid
Copy link
Member

ypid commented Nov 6, 2021

See #397 (comment) and #300.

@Lee-Carre
Copy link
Author

Lee-Carre commented Dec 19, 2021

OK, but what's the problem with leaving it open in order that it receive attention?

When I'm able to, then I will, myself. Unless someone takes it on first.

@ypid
Copy link
Member

ypid commented Dec 19, 2021

The issue is that open issues take at least some of my maintenance time when I look though open issues. But alright, as you are persistent, I will reopen it.

@ypid ypid reopened this Dec 19, 2021
@Lee-Carre
Copy link
Author

open issues take at least some of my maintenance time when I look though open issues.

I see. Understandable.

How about marking it in order to filter-out those of no interest in your default view of issues?
Suggestions:

  • tagging as minor or country dateset additions
  • assigning it (to me)

Same for #398 please.

@Lee-Carre Lee-Carre linked a pull request Dec 30, 2021 that will close this issue
@Lee-Carre
Copy link
Author

For future reference, after I get around to nagging the local bureaucrats about publishing various data in useful formats (with permissive licensing), PH data would appear on opendata.gov.je (possibly with the holiday tag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation. type: feature Introduction of new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants