Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Zealand public holidays #333

Merged
merged 2 commits into from
Jul 1, 2020
Merged

New Zealand public holidays #333

merged 2 commits into from
Jul 1, 2020

Conversation

Mortein
Copy link

@Mortein Mortein commented Jun 30, 2020

Added the 10 statutory holidays in New Zealand.

Technically, there's an 11th "provincial holiday", which varies by province. Provinces have since been replaced with Regions, but the holiday is still official. Regions somewhat match the old Provinces, but they are different. Wikipedia explains this much better than I can. As the state field from Nominatim contains Region, I'm not sure it's easily possible to match the provincial holidays to their correct locations.

The 10 statutory holidays
No provincial holidays, as State doesn't match old names
@Mortein
Copy link
Author

Mortein commented Jun 30, 2020

If you'd like an accompanying issue, let me know and I'll create it.

Checked the legislation, and it should be Anzac, not ANZAC
@Mortein
Copy link
Author

Mortein commented Jun 30, 2020

The legislation for Anzac Day uses Anzac Day, not ANZAC Day.

Wikipedia and its sources (including the Holidays Act and Employment New Zealand) are incorrect.

@ypid
Copy link
Member

ypid commented Jun 30, 2020

You made my day. First holiday definition PR in a while that looks good as is and even adds a unit test. Thank you :)

If you'd like an accompanying issue, let me know and I'll create it.

Holiday definitions (and even worse school holidays) are not meant to be logical or easy for GIS systems. If you can provide a solution based on OSM data, I can merge it, otherwise, I am afraid, I cannot spend the time to work out solutions for all special cases of all countries in the world. Also, please have a look at #300.

./PH_SH_exporter.js --from 2020 --to 2021 /tmp/out -c nz -p -v -r nz                                                                  
2020-01-01 New Year's Day
2020-01-02 Day after New Year's Day
2020-02-06 Waitangi Day
2020-04-10 Good Friday
2020-04-13 Easter Monday
2020-04-25 Anzac Day
2020-06-01 Queen's Birthday
2020-10-26 Labour Day
2020-12-25 Christmas Day
2020-12-26 Boxing Day
2021-01-01 New Year's Day
2021-01-02 Day after New Year's Day
2021-02-06 Waitangi Day
2021-04-02 Good Friday
2021-04-05 Easter Monday
2021-04-25 Anzac Day
2021-06-07 Queen's Birthday
2021-10-25 Labour Day
2021-12-25 Christmas Day
2021-12-26 Boxing Day

Should I merge this then? You are free to submit a solution for the special case when you have something robust. I will add a hint to the README that this special case exists (rather than tracking it as issue here).

@Mortein
Copy link
Author

Mortein commented Jun 30, 2020

Yeah, please merge this. It's at least a step in the right direction and 10/11 ain't bad.

If I think of a nice way for the Provincial holidays, I'll make another PR.

ypid added a commit that referenced this pull request Jul 1, 2020
ypid added a commit that referenced this pull request Jul 1, 2020
@ypid ypid merged commit fe6a788 into opening-hours:master Jul 1, 2020
@ypid
Copy link
Member

ypid commented Jul 1, 2020

All right. Merged and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants