Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update fields of the different auth types #1334

Closed
russojrv-zz opened this issue Oct 15, 2021 · 1 comment · Fixed by #1336
Closed

Allow update fields of the different auth types #1334

russojrv-zz opened this issue Oct 15, 2021 · 1 comment · Fixed by #1336

Comments

@russojrv-zz
Copy link

In the OIH framework, right now, it only allows you to update the auth client basic fields from its schema. In case, you want to update some no common fields you cannot

  • Allow update fields from different types of auth types
  • One limitation is that you have to be sure that you send the auth type in the body

Solution Proposal

const result = await AuthClient[data.type].findOneAndUpdate({ _id: id, }, updateOperation, { new: true, }).lean();

@heggert
Copy link
Member

heggert commented Oct 20, 2021

Please checkout #1336

@heggert heggert linked a pull request Oct 20, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants