We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When you try to get all secrets of one auth client, it never returns items. The problem is that one await is missing in the code.
Expected behavior Get all secrets of an auth client.
To Reproduce
Solution Add the await to the corresponding method.
services/secret-service/src/route/auth-clients/index.js (Add the await) const secrets = await findByAuthClient( req.user.sub, authClient._id, ); services/secret-service/src/dao/secret.js (Remove await/async and return the Promise)
const secrets = await findByAuthClient( req.user.sub, authClient._id, );
findByAuthClient( id, authClientId, ) { return Secret.full.find({ 'value.authClientId': authClientId, 'owners.id': id, }, 'name type value.authClientId value.scope value.expires value.externalId owners currentError', ); },
The text was updated successfully, but these errors were encountered:
Fixed with #1336
Sorry, something went wrong.
weberjm
Successfully merging a pull request may close this issue.
Describe the bug
When you try to get all secrets of one auth client, it never returns items. The problem is that one await is missing in the code.
Expected behavior
Get all secrets of an auth client.
To Reproduce
Solution
Add the await to the corresponding method.
services/secret-service/src/route/auth-clients/index.js (Add the await)
const secrets = await findByAuthClient( req.user.sub, authClient._id, );
services/secret-service/src/dao/secret.js (Remove await/async and return the Promise)
findByAuthClient( id, authClientId, ) { return Secret.full.find({ 'value.authClientId': authClientId, 'owners.id': id, }, 'name type value.authClientId value.scope value.expires value.externalId owners currentError', ); },
The text was updated successfully, but these errors were encountered: