Merge pull request #18 from openizr/0.0.27

Update cache when using setValues only if enabled
openizr · Aug 27, 2021 · 43755d0 · 43755d0
2 parents 7273d60 + 9325e49
commit 43755d0
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 16 deletions.
diff --git a/library/src/scripts/core/Engine.ts b/library/src/scripts/core/Engine.ts
@@ -414,22 +414,24 @@ export default class Engine {
    */
   public setValues(values: FormValues): void {
     Object.assign(this.formValues, deepCopy(values));
-    localforage.setItem(this.cacheKey, {
-      formValues: this.formValues,
-      // We remove all functions from fields' options as they can't be stored in IndexedDB.
-      steps: this.generatedSteps.map((step) => ({
-        ...step,
-        fields: step.fields.map((field) => ({
-          ...field,
-          options: Object.keys(field.options).reduce((options, key) => {
-            if (typeof field.options[key] !== 'function') {
-              Object.assign(options, { [key]: field.options[key] });
-            }
-            return options;
-          }, {}),
+    if (this.useCache) {
+      localforage.setItem(this.cacheKey, {
+        formValues: this.formValues,
+        // We remove all functions from fields' options as they can't be stored in IndexedDB.
+        steps: this.generatedSteps.map((step) => ({
+          ...step,
+          fields: step.fields.map((field) => ({
+            ...field,
+            options: Object.keys(field.options).reduce((options, key) => {
+              if (typeof field.options[key] !== 'function') {
+                Object.assign(options, { [key]: field.options[key] });
+              }
+              return options;
+            }, {}),
+          })),
         })),
-      })),
-    });
+      });
+    }
   }
 
   /**

diff --git a/library/src/scripts/core/__tests__/Engine.test.ts b/library/src/scripts/core/__tests__/Engine.test.ts
@@ -592,7 +592,7 @@ describe('core/Engine', () => {
     expect(() => engine.createStep('other')).toThrow(new Error('Step "other" does not exist.'));
   });
 
-  test('getValues & setValues', async () => {
+  test('getValues & setValues - cache enabled', async () => {
     await createEngine({
       root: 'test',
       steps: { test: { fields: ['test'] } },
@@ -620,6 +620,18 @@ describe('core/Engine', () => {
     });
   });
 
+  test('setValues - cache disabled', async () => {
+    await createEngine({
+      root: 'test',
+      cache: false,
+      steps: { test: { fields: [] } },
+      fields: {},
+    });
+    engine.setValues({ test: 'test', other: 'other' });
+    expect(engine.getValues()).toEqual({ test: 'test', other: 'other' });
+    expect(localforage.setItem).not.toHaveBeenCalled();
+  });
+
   test('getStore', async () => {
     await createEngine({ root: 'test', steps: { test: { fields: [] } }, fields: {} });
     expect(store).toBe(engine.getStore());