Refactor type element

[PaulSandoz]

Rename TypeElement to CodeType, thereby avoiding confusion with javax.lang.model.element.TypeElement (CodeType is closer to javax.lang.model.type.TypeMirror and java.lang.reflect.Type).

Rename TypeDefintion to ExternalizedCodeType and enclose within CodeType.

It's possible to go further and define a subtype ExternalizableCodeType that supports externalization to ExternalizedCodeType, copying the pattern for operations. This requires some adjustments to the externalization of types that may be composed of other posssibly non-externalizable types e.g. FunctionType. We can consider this separately to this PR.

---

Progress

• Change must not contain extraneous whitespace

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.org/babylon.git pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/70.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Refactor type element

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (7b9dc795)

[mcimadamore]

Have you considered the name OpType? Since the code model API is mainly about "ops" and types are meta-data attached to such ops, the name seems a bit less general than "code type".

[mcimadamore]

It's possible to go further and define a subtype ExternalizableCodeType that supports externalization to ExternalizedCodeType, copying the pattern for operations.

Yeah. that would seem more consistent with what with did with Ops. Also I note there's an externalize method that throws UOE on non-externalizable types which seems to call for pattern match. (But that can some i a separate PR)

[PaulSandoz]

Have you considered the name OpType? Since the code model API is mainly about "ops" and types are meta-data attached to such ops, the name seems a bit less general than "code type".

(Code) Types are associated with results of operations and parameters of blocks. I did ponder ValueType, WDYT?
I was concerned with any misleading association with Valhalla, but that's likely silly since we already have Value.

[PaulSandoz]

On further reflection i will close this issue without integrating. It seems unnecessary churn right now. I will create another PR that focuses on the less disruptive refactor of TypeDefinition to ExternalizedTypeElement.