Ignore errors parsing classpath #149
Conversation
|
👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into |
|
@rvansa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
openjdk
bot
added
ready
Webrevs
|
|
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
| CLASSPATH_ENTRIES[i] = new File(items[i]).toPath(); | ||
| } catch (Exception e) { | ||
| // Ignore any exception parsing the path: URLClassPath.toFileURL() ignores IOExceptions | ||
| // as well, here we might get InvalidPathException |
There was a problem hiding this comment.
I think CLASSPATH_ENTRIES[i] will remain null in such case and later code in this file accesses it without a null check. But I haven't tried to reproduce it on Windows.
There was a problem hiding this comment.
Correct, I need to push an update to this.
There was a problem hiding this comment.
Updated, with improved test.
|
@rvansa This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@rvansa This pull request is now open |
|
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
/open |
|
@rvansa This pull request is already open |
|
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This test is relevant mostly on Windows - trying to use URI in the form of
file:/C:/path/to/...as classpath element. On Linux, this is parsed as two items asFile.pathSeparatoris:. However on Windows the second colon triggers an exception.Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/149/head:pull/149$ git checkout pull/149Update a local copy of the PR:
$ git checkout pull/149$ git pull https://git.openjdk.org/crac.git pull/149/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 149View PR using the GUI difftool:
$ git pr show -t 149Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/149.diff
Webrev
Link to Webrev Comment