New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CRaC tests #47
Conversation
👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into |
@rvansa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AntonKozlov) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
/integrate |
/sponsor |
@AntonKozlov @rvansa Pushed as commit 80cab69. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Before #16 the arguments for restored process were ignored; tests were written with this in mind and current behaviour breaks them.
In addition I've added missing
-XX:+UnlockDiagnosticVMOptions
flag and fixed therecursiveCheckpoint
test runner which got stuck as withpauseengine
the checkpointed process does not terminate.Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac pull/47/head:pull/47
$ git checkout pull/47
Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/crac pull/47/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 47
View PR using the GUI difftool:
$ git pr show -t 47
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/47.diff