Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CRaC tests #47

Closed
wants to merge 2 commits into from
Closed

Fix failing CRaC tests #47

wants to merge 2 commits into from

Conversation

rvansa
Copy link
Collaborator

@rvansa rvansa commented Feb 22, 2023

Before #16 the arguments for restored process were ignored; tests were written with this in mind and current behaviour breaks them.

In addition I've added missing -XX:+UnlockDiagnosticVMOptions flag and fixed the recursiveCheckpoint test runner which got stuck as with pauseengine the checkpointed process does not terminate.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/crac pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/47.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2023

👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 22, 2023

@rvansa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Fix failing CRaC tests

Reviewed-by: akozlov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the crac branch:

  • 0738da8: Close extraneous file descriptors
  • 7dfaf5f: DNS cache maintenance

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AntonKozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2023

Webrevs

Copy link
Member

@AntonKozlov AntonKozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@rvansa
Copy link
Collaborator Author

rvansa commented Mar 1, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@rvansa
Your change (at version 3b9598b) is now ready to be sponsored by a Committer.

@AntonKozlov
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 1, 2023

Going to push as commit 80cab69.
Since your change was applied there have been 2 commits pushed to the crac branch:

  • 0738da8: Close extraneous file descriptors
  • 7dfaf5f: DNS cache maintenance

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2023
@openjdk openjdk bot closed this Mar 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@AntonKozlov @rvansa Pushed as commit 80cab69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rvansa rvansa deleted the fix-crac-tests branch March 23, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants