Skip to content

Commit

Permalink
8252868: Clean up unused function from G1MMUTracker
Browse files Browse the repository at this point in the history
Reviewed-by: tschatzl
  • Loading branch information
kstefanj committed Sep 8, 2020
1 parent 891886b commit 188b0bc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp
Expand Up @@ -80,7 +80,7 @@ class CMCleanup : public VoidClosure {
double G1ConcurrentMarkThread::mmu_delay_end(G1Policy* g1_policy, bool remark) {
// There are 3 reasons to use SuspendibleThreadSetJoiner.
// 1. To avoid concurrency problem.
// - G1MMUTracker::add_pause(), when_sec() and its variation(when_ms() etc..) can be called
// - G1MMUTracker::add_pause(), when_sec() and when_max_gc_sec() can be called
// concurrently from ConcurrentMarkThread and VMThread.
// 2. If currently a gc is running, but it has not yet updated the MMU,
// we will not forget to consider that pause in the MMU calculation.
Expand Down
14 changes: 0 additions & 14 deletions src/hotspot/share/gc/g1/g1MMUTracker.hpp
Expand Up @@ -62,23 +62,9 @@ class G1MMUTracker: public CHeapObj<mtGC> {
return _max_gc_time;
}

inline bool now_max_gc(double current_time) {
return when_sec(current_time, max_gc_time()) < 0.00001;
}

inline double when_max_gc_sec(double current_time) {
return when_sec(current_time, max_gc_time());
}

inline jlong when_max_gc_ms(double current_time) {
double when = when_max_gc_sec(current_time);
return (jlong) (when * 1000.0);
}

inline jlong when_ms(double current_time, double pause_time) {
double when = when_sec(current_time, pause_time);
return (jlong) (when * 1000.0);
}
};

class G1MMUTrackerQueueElem {
Expand Down

1 comment on commit 188b0bc

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented on 188b0bc Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

Please sign in to comment.