Skip to content

Commit

Permalink
8293340: Remove unused _code in {Zero,Template}InterpreterGenerator
Browse files Browse the repository at this point in the history
Reviewed-by: jiefu, shade
  • Loading branch information
bobpengxie authored and DamonFool committed Sep 6, 2022
1 parent 26f2a97 commit 272745b
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/hotspot/cpu/zero/zeroInterpreter_zero.cpp
Expand Up @@ -65,7 +65,7 @@ void ZeroInterpreter::initialize_code() {
// generate interpreter
{ ResourceMark rm;
TraceTime timer("Interpreter generation", TRACETIME_LOG(Info, startuptime));
ZeroInterpreterGenerator g(_code);
ZeroInterpreterGenerator g;
if (PrintInterpreter) print();
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/interpreter/abstractInterpreter.cpp
Expand Up @@ -96,7 +96,7 @@ address AbstractInterpreter::_native_abi_to_tosca [AbstractInterpreter::nu
//------------------------------------------------------------------------------------------------------------------------
// Generation of complete interpreter

AbstractInterpreterGenerator::AbstractInterpreterGenerator(StubQueue* _code) {
AbstractInterpreterGenerator::AbstractInterpreterGenerator() {
_masm = NULL;
}

Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/interpreter/abstractInterpreter.hpp
Expand Up @@ -295,7 +295,7 @@ class AbstractInterpreterGenerator: public StackObj {
InterpreterMacroAssembler* _masm;

public:
AbstractInterpreterGenerator(StubQueue* _code);
AbstractInterpreterGenerator();
};

#endif // SHARE_INTERPRETER_ABSTRACTINTERPRETER_HPP
2 changes: 1 addition & 1 deletion src/hotspot/share/interpreter/templateInterpreter.cpp
Expand Up @@ -63,7 +63,7 @@ void TemplateInterpreter::initialize_code() {
// generate interpreter
{ ResourceMark rm;
TraceTime timer("Interpreter generation", TRACETIME_LOG(Info, startuptime));
TemplateInterpreterGenerator g(_code);
TemplateInterpreterGenerator g;
// Free the unused memory not occupied by the interpreter and the stubs
_code->deallocate_unused_tail();
}
Expand Down
Expand Up @@ -34,7 +34,7 @@

#define __ Disassembler::hook<InterpreterMacroAssembler>(__FILE__, __LINE__, _masm)->

TemplateInterpreterGenerator::TemplateInterpreterGenerator(StubQueue* _code): AbstractInterpreterGenerator(_code) {
TemplateInterpreterGenerator::TemplateInterpreterGenerator(): AbstractInterpreterGenerator() {
_unimplemented_bytecode = NULL;
_illegal_bytecode_sequence = NULL;
generate_all();
Expand Down
Expand Up @@ -127,7 +127,7 @@ class TemplateInterpreterGenerator: public AbstractInterpreterGenerator {
#endif // PPC

public:
TemplateInterpreterGenerator(StubQueue* _code);
TemplateInterpreterGenerator();
};

#endif // !ZERO
Expand Down
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright 2007, 2008, 2009, 2010, 2011 Red Hat, Inc.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -32,7 +32,7 @@
#include "oops/method.hpp"
#include "zeroInterpreterGenerator.hpp"

ZeroInterpreterGenerator::ZeroInterpreterGenerator(StubQueue* _code): AbstractInterpreterGenerator(_code) {
ZeroInterpreterGenerator::ZeroInterpreterGenerator(): AbstractInterpreterGenerator() {
generate_all();
}

Expand Down
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -49,7 +49,7 @@ class ZeroInterpreterGenerator: public AbstractInterpreterGenerator {
address generate_Reference_get_entry();

public:
ZeroInterpreterGenerator(StubQueue* _code);
ZeroInterpreterGenerator();

protected:
MacroAssembler* assembler() const {
Expand Down

1 comment on commit 272745b

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.