Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8285914: AppCDS crash when using shared archive with old class file
Reviewed-by: dholmes, iklam
- Loading branch information
1 parent
fe6e0c0
commit 29ccb8f
Showing
6 changed files
with
226 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
* | ||
*/ | ||
/* | ||
* @test | ||
* @bug 8285914 | ||
* @summary A lambda proxy class should not be archived if its nest host implements an | ||
* old (with major version < JDK_6 (50)) interface which cannot be verified during dump time. | ||
* @requires vm.cds | ||
* @library /test/lib | ||
* @compile test-classes/OldInf.jasm test-classes/ChildOldInf.java test-classes/NestHostOldInfApp.java | ||
* @run driver NestHostOldInf | ||
*/ | ||
|
||
import jdk.test.lib.cds.CDSTestUtils; | ||
import jdk.test.lib.process.OutputAnalyzer; | ||
|
||
public class NestHostOldInf { | ||
|
||
public static void main(String[] args) throws Exception { | ||
String mainClass = "NestHostOldInfApp"; | ||
String namePrefix = "oldsuperinf"; | ||
String appClasses[] = TestCommon.list("OldInf", "ChildOldInf", "ChildOldInf$InnerChild", mainClass); | ||
JarBuilder.build(namePrefix, appClasses); | ||
|
||
String appJar = TestCommon.getTestJar(namePrefix + ".jar"); | ||
String archiveName = namePrefix + ".jsa"; | ||
|
||
boolean dynamicMode = CDSTestUtils.DYNAMIC_DUMP; | ||
|
||
// create archive with class list | ||
OutputAnalyzer output = TestCommon.dump(appJar, appClasses, "-Xlog:class+load,cds=debug,verification=trace"); | ||
TestCommon.checkExecReturn(output, 0, | ||
dynamicMode ? true : false, | ||
"Skipping OldInf: Old class has been linked", | ||
"Skipping ChildOldInf: Old class has been linked"); | ||
|
||
// run with archive | ||
TestCommon.run( | ||
"-cp", appJar, | ||
"-Xlog:class+load,cds=debug,verification=trace", | ||
mainClass) | ||
.assertNormalExit(out -> { | ||
out.shouldContain("Verifying class OldInf with old format") | ||
.shouldContain("Verifying class ChildOldInf with new format") | ||
.shouldContain("ChildOldInf$InnerChild source: shared objects file") | ||
.shouldContain("Hello from InnerChild doTest"); | ||
if (!dynamicMode) { | ||
out.shouldContain("OldInf source: shared objects file") | ||
.shouldContain("ChildOldInf source: shared objects file"); | ||
} else { | ||
// Old classes were already linked before dynamic dump happened, | ||
// so they couldn't be archived. | ||
out.shouldMatch(".class.load.*OldInf source:.*oldsuperinf.jar") | ||
.shouldMatch(".class.load.*ChildOldInf source:.*oldsuperinf.jar"); | ||
} | ||
}); | ||
} | ||
} |
89 changes: 89 additions & 0 deletions
89
test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/NestHostOldInf.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
* | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @bug 8285914 | ||
* @summary A lambda proxy class should not be archived if its nest host implements an | ||
* old (with major version < JDK_6 (50)) interface which cannot be verified during dump time. | ||
* @requires vm.cds | ||
* @requires vm.cds.custom.loaders | ||
* @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds | ||
* @compile ../test-classes/OldInf.jasm ../test-classes/ChildOldInf.java ../test-classes/NestHostOldInfApp.java | ||
* @build sun.hotspot.WhiteBox | ||
* @run driver jdk.test.lib.helpers.ClassFileInstaller -jar oldclassapp.jar NestHostOldInfApp OldInf ChildOldInf ChildOldInf$InnerChild | ||
* @run driver jdk.test.lib.helpers.ClassFileInstaller -jar WhiteBox.jar sun.hotspot.WhiteBox | ||
* @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:./WhiteBox.jar NestHostOldInf | ||
*/ | ||
|
||
import java.io.File; | ||
import jdk.test.lib.cds.CDSTestUtils; | ||
import jdk.test.lib.process.OutputAnalyzer; | ||
import jdk.test.lib.helpers.ClassFileInstaller; | ||
|
||
public class NestHostOldInf extends DynamicArchiveTestBase { | ||
private static final String ARCHIVE_NAME = CDSTestUtils.getOutputFileName("oldclass-top.jsa"); | ||
private static String wbJar = ClassFileInstaller.getJarPath("WhiteBox.jar"); | ||
private static String use_whitebox_jar = "-Xbootclasspath/a:" + wbJar; | ||
private static String appJar = ClassFileInstaller.getJarPath("oldclassapp.jar"); | ||
private static String mainAppClass = "NestHostOldInfApp"; | ||
|
||
public static void main(String[] args) throws Exception { | ||
runTest(NestHostOldInf::doTest); | ||
} | ||
|
||
private static void doTest() throws Exception { | ||
dump(ARCHIVE_NAME, | ||
use_whitebox_jar, | ||
"-XX:+UnlockDiagnosticVMOptions", | ||
"-XX:+WhiteBoxAPI", | ||
"-Xlog:cds", | ||
"-Xlog:cds+dynamic=debug", | ||
"-cp", appJar, | ||
mainAppClass) | ||
.assertNormalExit(output -> { | ||
output.shouldContain("Written dynamic archive 0x") | ||
.shouldContain("Skipping ChildOldInf: Old class has been linked") | ||
.shouldContain("Skipping OldInf: Old class has been linked") | ||
.shouldHaveExitValue(0); | ||
}); | ||
|
||
run(ARCHIVE_NAME, | ||
use_whitebox_jar, | ||
"-XX:+UnlockDiagnosticVMOptions", | ||
"-XX:+WhiteBoxAPI", | ||
"-Xlog:class+load", | ||
"-Xlog:cds=debug", | ||
"-Xlog:cds+dynamic=info", | ||
"-cp", appJar, | ||
mainAppClass) | ||
.assertNormalExit(output -> { | ||
output.shouldHaveExitValue(0) | ||
.shouldMatch(".class.load. OldInf source:.*oldclassapp.jar") | ||
.shouldMatch(".class.load. ChildOldInf source:.*oldclassapp.jar") | ||
.shouldContain("ChildOldInf$InnerChild source: shared objects file (top)") | ||
.shouldMatch(".class.load. ChildOldInf[$]InnerChild[$][$]Lambda[$].*/0x.*source:.ChildOldInf"); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
test/hotspot/jtreg/runtime/cds/appcds/test-classes/NestHostOldInfApp.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
* | ||
*/ | ||
public class NestHostOldInfApp { | ||
public static void main(String args[]) { | ||
ChildOldInf.innerChild().doTest(); | ||
} | ||
} |
29ccb8f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues