Do not print void warning with -XX:-PrintWarnings

openjdk · Dec 4, 2020 · 306cd96 · 306cd96
1 parent f0d5f73
commit 306cd96
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 13 deletions.
diff --git a/src/hotspot/share/compiler/compilerOracle.cpp b/src/hotspot/share/compiler/compilerOracle.cpp
@@ -414,9 +414,8 @@ bool CompilerOracle::should_blackhole(const methodHandle& method) {
     if (method->result_type() == T_VOID) {
       return true;
     } else {
-      ttyLocker ttyl;
-      tty->print_cr("Warning: blackhole compile command only works for methods with void type: %s",
-                    method->name_and_sig_as_C_string());
+      warning("blackhole compile command only works for methods with void type: %s",
+              method->name_and_sig_as_C_string());
     }
   }
   return false;

diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeNonVoidWarning.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeNonVoidWarning.java
@@ -48,16 +48,34 @@ public static void main(String[] args) throws IOException {
     }
 
     public static void driver() throws IOException {
-        ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
-            "-Xmx128m",
-            "-XX:CompileCommand=quiet",
-            "-XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_*",
-            "compiler.blackhole.BlackholeNonVoidWarning",
-            "run"
-        );
-        OutputAnalyzer output = new OutputAnalyzer(pb.start());
-        output.shouldHaveExitValue(0);
-        output.shouldContain("blackhole compile command only works for methods with void type: compiler.blackhole.BlackholeTarget.bh_sr_int(I)I");
+       final String msg = "blackhole compile command only works for methods with void type: compiler.blackhole.BlackholeTarget.bh_sr_int(I)I";
+
+       {
+           ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
+               "-Xmx128m",
+               "-XX:CompileCommand=quiet",
+               "-XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_*",
+               "compiler.blackhole.BlackholeNonVoidWarning",
+               "run"
+           );
+           OutputAnalyzer output = new OutputAnalyzer(pb.start());
+           output.shouldHaveExitValue(0);
+           output.shouldContain(msg);
+       }
+
+       {
+           ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
+               "-Xmx128m",
+               "-XX:-PrintWarnings",
+               "-XX:CompileCommand=quiet",
+               "-XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_*",
+               "compiler.blackhole.BlackholeNonVoidWarning",
+               "run"
+           );
+           OutputAnalyzer output = new OutputAnalyzer(pb.start());
+           output.shouldHaveExitValue(0);
+           output.shouldNotContain(msg);
+       }
     }
 
     public static void runner() {