8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile

Reviewed-by: dnsimon, never

Author: David Leopoldseder

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotSpeculationLog.java

@@ -207,11 +207,14 @@ byte[] getFlattenedSpeculations(boolean validate) {
         return result;
     }
 
+    /**
+     * @return {@code true} if the given speculation can be performed, i.e., it never failed so far, otherwise
+     * return {@code false}. Note, that this method returns consistent results for any given speculation for the
+     * entire lifetime of the enclosing SpeculationLog object. This means that speculations failed during a
+     * compilation will not be updated.
+     */
     @Override
     public boolean maySpeculate(SpeculationReason reason) {
-        if (failedSpeculations == null) {
-            collectFailedSpeculations();
-        }
         if (failedSpeculations != null && failedSpeculations.length != 0) {
             byte[] encoding = encode(reason);
             return !contains(failedSpeculations, 0, encoding);