8265047: Inconsistent warning message in jcmd VM.log

Reviewed-by: dholmes, stuefe, sspitsyn
openjdk · May 6, 2021 · 51f5adf · 51f5adf · openjdk-notifier · May 6, 2021
1 parent ea30bd6
commit 51f5adf
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/hotspot/share/logging/logConfiguration.cpp b/src/hotspot/share/logging/logConfiguration.cpp
@@ -427,6 +427,7 @@ bool LogConfiguration::parse_log_arguments(const char* outputstr,
 
   ConfigurationLock cl;
   size_t idx;
+  bool added = false;
   if (outputstr[0] == '#') { // Output specified using index
     int ret = sscanf(outputstr + 1, SIZE_FORMAT, &idx);
     if (ret != 1 || idx >= _n_outputs) {
@@ -447,16 +448,18 @@ bool LogConfiguration::parse_log_arguments(const char* outputstr,
       LogOutput* output = new_output(normalized, output_options, errstream);
       if (output != NULL) {
         idx = add_output(output);
+        added = true;
       }
-    } else if (output_options != NULL && strlen(output_options) > 0) {
-      errstream->print_cr("Output options for existing outputs are ignored.");
     }
 
     FREE_C_HEAP_ARRAY(char, normalized);
     if (idx == SIZE_MAX) {
       return false;
     }
   }
+  if (!added && output_options != NULL && strlen(output_options) > 0) {
+    errstream->print_cr("Output options for existing outputs are ignored.");
+  }
   configure_output(idx, selections, decorators);
   notify_update_listeners();
   selections.verify_selections(errstream);