Skip to content

Commit 5489c82

Browse files
Glavonaotoj
authored andcommitted
8302603: Use Set.of in java.nio.charset.Charset
Reviewed-by: stsypanov, alanb, naoto
1 parent 10b4cc9 commit 5489c82

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/java.base/share/classes/java/nio/charset/Charset.java

+7-10
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import java.security.PrivilegedAction;
3939
import java.util.Arrays;
4040
import java.util.Collections;
41-
import java.util.HashSet;
4241
import java.util.Iterator;
4342
import java.util.Locale;
4443
import java.util.Map;
@@ -667,7 +666,7 @@ public static Charset defaultCharset() {
667666

668667
private final String name; // tickles a bug in oldjavac
669668
private final String[] aliases; // tickles a bug in oldjavac
670-
private Set<String> aliasSet = null;
669+
private Set<String> aliasSet;
671670

672671
/**
673672
* Initializes a new charset with the given canonical name and alias
@@ -714,14 +713,12 @@ public final String name() {
714713
* @return An immutable set of this charset's aliases
715714
*/
716715
public final Set<String> aliases() {
717-
if (aliasSet != null)
718-
return aliasSet;
719-
int n = aliases.length;
720-
HashSet<String> hs = HashSet.newHashSet(n);
721-
for (int i = 0; i < n; i++)
722-
hs.add(aliases[i]);
723-
aliasSet = Collections.unmodifiableSet(hs);
724-
return aliasSet;
716+
Set<String> set = this.aliasSet;
717+
if (set == null) {
718+
set = Set.of(aliases);
719+
this.aliasSet = set;
720+
}
721+
return set;
725722
}
726723

727724
/**

0 commit comments

Comments
 (0)