Skip to content

Commit

Permalink
8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and …
Browse files Browse the repository at this point in the history 
…Linux aarch64

Reviewed-by: mbaesken, stuefe
  • Loading branch information
@schmelter-sap
schmelter-sap committed Nov 15, 2022
1 parent 8a9eabb commit 5551cb6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java
View file
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2016, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -123,6 +123,7 @@ private static long runProcess(Class<?> crasher, String signal, boolean disk, St
List<String> options = new ArrayList<>();
options.add("-Xmx64m");
options.add("-XX:-CreateCoredumpOnCrash");
options.add("-XX:-TieredCompilation"); // Avoid secondary crashes (see JDK-8293166)
options.add("--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED");
options.add("-XX:StartFlightRecording:dumponexit=true,disk=" + Boolean.toString(disk));
if (dumppath != null) {
Expand Down

5 comments on commit 5551cb6

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@schmelter-sap
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 5551cb6 Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schmelter-sap Could not automatically backport 5551cb66 to openjdk/jdk17u-dev due to conflicts in the following files:

  • test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk17u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk17u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b schmelter-sap-backport-5551cb66

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 5551cb66ba58cadce7291a95c5af662ade2cb7b8

# Backport the commit
$ git cherry-pick --no-commit 5551cb66ba58cadce7291a95c5af662ade2cb7b8
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 5551cb66ba58cadce7291a95c5af662ade2cb7b8'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u-dev with the title Backport 5551cb66ba58cadce7291a95c5af662ade2cb7b8.

@schmelter-sap
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 5551cb6 Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schmelter-sap Could not automatically backport 5551cb66 to openjdk/jdk11u-dev due to conflicts in the following files:

  • test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b schmelter-sap-backport-5551cb66

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 5551cb66ba58cadce7291a95c5af662ade2cb7b8

# Backport the commit
$ git cherry-pick --no-commit 5551cb66ba58cadce7291a95c5af662ade2cb7b8
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 5551cb66ba58cadce7291a95c5af662ade2cb7b8'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport 5551cb66ba58cadce7291a95c5af662ade2cb7b8.

Please sign in to comment.