8309506: com/sun/jdi/MultiBreakpointsTest.java fails with virtual tes…

…t thread factory Reviewed-by: amenkov, sspitsyn
openjdk · Jun 6, 2023 · 571fbdc · 571fbdc · openjdk-notifier · Jun 6, 2023
1 parent 7d1147e
commit 571fbdc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/test/jdk/ProblemList-Virtual.txt b/test/jdk/ProblemList-Virtual.txt
@@ -30,7 +30,6 @@ com/sun/jdi/EATests.java#id0                                    8264699 generic-
 com/sun/jdi/ExceptionEvents.java 8278470 generic-all
 com/sun/jdi/JdbMethodExitTest.java 8285422 generic-all
 com/sun/jdi/MethodEntryExitEvents.java 8285422 generic-all
-com/sun/jdi/MultiBreakpointsTest.java 8285422 generic-all
 com/sun/jdi/RedefineCrossStart.java 8278470 generic-all
 com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java 8285422 generic-all
 com/sun/jdi/ReferrersTest.java 8285422 generic-all

diff --git a/test/jdk/com/sun/jdi/MultiBreakpointsTest.java b/test/jdk/com/sun/jdi/MultiBreakpointsTest.java
@@ -60,8 +60,16 @@
 class MultiBreakpointsTarg {
 
     MultiBreakpointsTarg(int numThreads, int numHits) {
+        Thread threads[] = new Thread[numThreads];
         for (int ii = 0; ii < numThreads; ii++) {
-            console(ii, numHits);
+            threads[ii] = console(ii, numHits);
+        }
+        for (int ii = 0; ii < numThreads; ii++) {
+            try {
+                threads[ii].join();
+            } catch (InterruptedException ie) {
+                throw new RuntimeException(ie);
+            }
         }
     }
 
@@ -127,16 +135,15 @@ void bkpt27() {}
     void bkpt28() {}
     void bkpt29() {}
 
-    void console(final int num, final int nhits) {
+    Thread console(final int num, final int nhits) {
         final InputStreamReader isr = new InputStreamReader(System.in);
         final BufferedReader    br  = new BufferedReader(isr);
 
         // Create the threads
         //
         //final String threadName = "DebuggeeThread: " + num;
         final String threadName = "" + num;
-        Thread thrd = new Thread( threadName ) {
-                public void run() {
+        Thread thrd = TestScaffold.newThread(() -> {
                     synchronized( isr ) {
                         boolean done = false;
                         try {
@@ -188,9 +195,11 @@ public void run() {
                         }
                     }
                 }
-            };
+            );
+        thrd.setName(threadName);
         thrd.setPriority(Thread.MAX_PRIORITY-1);
         thrd.start();
+        return thrd;
     }
 }