Skip to content

Commit

Permalink
8314242: Update applications/scimark/Scimark.java to accept VM flags
Browse files Browse the repository at this point in the history 
Reviewed-by: dholmes
  • Loading branch information
@lmesnik
lmesnik committed Aug 16, 2023
1 parent bc8e9f4 commit 6bf4a33
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions test/hotspot/jtreg/applications/scimark/Scimark.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -24,7 +24,6 @@
/*
* @test
* @library /test/lib
* @requires vm.flagless
* @run driver Scimark
*/

Expand All @@ -47,7 +46,9 @@ public static void main(String... args) throws Exception {
+ Scimark.class.getName(), e);
}

OutputAnalyzer output = new OutputAnalyzer(ProcessTools.createJavaProcessBuilder(
System.setProperty("test.noclasspath", "true");

OutputAnalyzer output = new OutputAnalyzer(ProcessTools.createTestJvm(
"-cp", artifacts.get("gov.nist.math.scimark-2.0").toString(),
"jnt.scimark2.commandline", "-large")
.start());
Expand Down

7 comments on commit 6bf4a33

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 6bf4a33 Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 6bf4a33 Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 6bf4a33 Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-6bf4a335 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6bf4a335 from the openjdk/jdk repository.

The commit being backported was authored by Leonid Mesnik on 16 Aug 2023 and was reviewed by David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-6bf4a335:GoeLin-backport-6bf4a335
$ git checkout GoeLin-backport-6bf4a335
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-6bf4a335

@openjdk
Copy link

@openjdk openjdk bot commented on 6bf4a33 Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-6bf4a335 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6bf4a335 from the openjdk/jdk repository.

The commit being backported was authored by Leonid Mesnik on 16 Aug 2023 and was reviewed by David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-6bf4a335:GoeLin-backport-6bf4a335
$ git checkout GoeLin-backport-6bf4a335
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-6bf4a335

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 6bf4a33 Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u

@openjdk
Copy link

@openjdk openjdk bot commented on 6bf4a33 Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-6bf4a335 in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6bf4a335 from the openjdk/jdk repository.

The commit being backported was authored by Leonid Mesnik on 16 Aug 2023 and was reviewed by David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git GoeLin-backport-6bf4a335:GoeLin-backport-6bf4a335
$ git checkout GoeLin-backport-6bf4a335
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git GoeLin-backport-6bf4a335

Please sign in to comment.