Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8303238: Create generalizations for existing LShift ideal transforms
Reviewed-by: redestad, thartmann
- Loading branch information
Showing
4 changed files
with
425 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
test/hotspot/jtreg/compiler/c2/irTests/LShiftLNodeIdealizationTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /* | ||
| * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
| package compiler.c2.irTests; | ||
|
|
||
| import jdk.test.lib.Asserts; | ||
| import compiler.lib.ir_framework.*; | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 8303238 | ||
| * @summary Test that Ideal transformations of LShiftLNode* are being performed as expected. | ||
| * @library /test/lib / | ||
| * @run driver compiler.c2.irTests.LShiftLNodeIdealizationTests | ||
| */ | ||
| public class LShiftLNodeIdealizationTests { | ||
| public static void main(String[] args) { | ||
| TestFramework.run(); | ||
| } | ||
|
|
||
| @Run(test = { "test3", "test4", "test5", "test6", "test7", "test8" }) | ||
| public void runMethod() { | ||
| long a = RunInfo.getRandom().nextLong(); | ||
| long b = RunInfo.getRandom().nextLong(); | ||
| long c = RunInfo.getRandom().nextLong(); | ||
| long d = RunInfo.getRandom().nextLong(); | ||
|
|
||
| long min = Long.MIN_VALUE; | ||
| long max = Long.MAX_VALUE; | ||
|
|
||
| assertResult(0); | ||
| assertResult(a); | ||
| assertResult(b); | ||
| assertResult(c); | ||
| assertResult(d); | ||
| assertResult(min); | ||
| assertResult(max); | ||
| } | ||
|
|
||
| @DontCompile | ||
| public void assertResult(long a) { | ||
| Asserts.assertEQ((a >> 4L) << 8L, test3(a)); | ||
| Asserts.assertEQ((a >>> 4L) << 8L, test4(a)); | ||
| Asserts.assertEQ((a >> 8L) << 4L, test5(a)); | ||
| Asserts.assertEQ((a >>> 8L) << 4L, test6(a)); | ||
| Asserts.assertEQ(((a >> 4L) & 0xFFL) << 8L, test7(a)); | ||
| Asserts.assertEQ(((a >>> 4L) & 0xFFL) << 8L, test8(a)); | ||
| } | ||
|
|
||
| @Test | ||
| @IR(failOn = { IRNode.RSHIFT }) | ||
| @IR(counts = { IRNode.AND, "1", IRNode.LSHIFT, "1" }) | ||
| // Checks (x >> 4) << 8 => (x << 4) & -16 | ||
| public long test3(long x) { | ||
| return (x >> 4L) << 8L; | ||
| } | ||
|
|
||
| @Test | ||
| @IR(failOn = { IRNode.URSHIFT }) | ||
| @IR(counts = { IRNode.AND, "1", IRNode.LSHIFT, "1" }) | ||
| // Checks (x >>> 4) << 8 => (x << 4) & -16 | ||
| public long test4(long x) { | ||
| return (x >>> 4L) << 8L; | ||
| } | ||
|
|
||
| @Test | ||
| @IR(failOn = { IRNode.LSHIFT }) | ||
| @IR(counts = { IRNode.AND, "1", IRNode.RSHIFT, "1" }) | ||
| // Checks (x >> 8) << 4 => (x >> 4) & -16 | ||
| public long test5(long x) { | ||
| return (x >> 8L) << 4L; | ||
| } | ||
|
|
||
| @Test | ||
| @IR(failOn = { IRNode.LSHIFT }) | ||
| @IR(counts = { IRNode.AND, "1", IRNode.URSHIFT, "1" }) | ||
| // Checks (x >>> 8) << 4 => (x >>> 4) & -16 | ||
| public long test6(long x) { | ||
| return (x >>> 8L) << 4L; | ||
| } | ||
|
|
||
| @Test | ||
| @IR(failOn = { IRNode.RSHIFT }) | ||
| @IR(counts = { IRNode.AND, "1", IRNode.LSHIFT, "1" }) | ||
| // Checks ((x >> 4) & 0xFF) << 8 => (x << 4) & 0xFF00 | ||
| public long test7(long x) { | ||
| return ((x >> 4L) & 0xFFL) << 8L; | ||
| } | ||
|
|
||
| @Test | ||
| @IR(failOn = { IRNode.URSHIFT }) | ||
| @IR(counts = { IRNode.AND, "1", IRNode.LSHIFT, "1" }) | ||
| // Checks ((x >>> 4) & 0xFF) << 8 => (x << 4) & 0xFF00 | ||
| public long test8(long x) { | ||
| return ((x >>> 4L) & 0xFFL) << 8L; | ||
| } | ||
| } |
Oops, something went wrong.
8e41bf2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues