Skip to content
Permalink
Browse files
8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
Reviewed-by: egahlin, shade
  • Loading branch information
Markus Grönlund committed Dec 6, 2021
1 parent 6994d80 commit a885aab696777c99c8c4c5d9a46afc5fe0a4fe47
Showing 1 changed file with 6 additions and 2 deletions.
@@ -151,8 +151,12 @@ int JfrThreadGroupsHelper::populate_thread_group_hierarchy(const JavaThread* jt,
assert(current != NULL, "invariant");
assert(_thread_group_hierarchy != NULL, "invariant");

oop thread_oop = jt->threadObj();
if (thread_oop == nullptr) {
return 0;
}
// immediate thread group
Handle thread_group_handle(current, java_lang_Thread::threadGroup(jt->threadObj()));
Handle thread_group_handle(current, java_lang_Thread::threadGroup(thread_oop));
if (thread_group_handle == NULL) {
return 0;
}
@@ -167,7 +171,7 @@ int JfrThreadGroupsHelper::populate_thread_group_hierarchy(const JavaThread* jt,
Handle parent_thread_group_handle(current, parent_thread_group_obj);

// and check parents parents...
while (!(parent_thread_group_handle == NULL)) {
while (parent_thread_group_handle != nullptr) {
const jweak parent_group_weak_ref = use_weak_handles ? JNIHandles::make_weak_global(parent_thread_group_handle) : NULL;
thread_group_pointers = new JfrThreadGroupPointers(parent_thread_group_handle, parent_group_weak_ref);
_thread_group_hierarchy->append(thread_group_pointers);

1 comment on commit a885aab

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on a885aab Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.