Skip to content

Commit

Permalink
8230731: SA tests fail with "Windbg Error: ReadVirtual failed
Browse files Browse the repository at this point in the history
Reviewed-by: amenkov, sspitsyn
  • Loading branch information
plummercj committed Apr 16, 2020
1 parent 3efd000 commit c6c1f9b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
8 changes: 3 additions & 5 deletions src/jdk.hotspot.agent/windows/native/libsaproc/sawindbg.cpp
Expand Up @@ -728,11 +728,9 @@ JNIEXPORT jbyteArray JNICALL Java_sun_jvm_hotspot_debugger_windbg_WindbgDebugger
CHECK_EXCEPTION_(0);

ULONG bytesRead;
COM_VERIFY_OK_(ptrIDebugDataSpaces->ReadVirtual((ULONG64)address, arrayBytes,
(ULONG)numBytes, &bytesRead),
"Windbg Error: ReadVirtual failed!", 0);

if (bytesRead != numBytes) {
const HRESULT hr = ptrIDebugDataSpaces->ReadVirtual((ULONG64)address, arrayBytes,
(ULONG)numBytes, &bytesRead);
if (hr != S_OK || bytesRead != numBytes) {
return 0;
}

Expand Down
4 changes: 2 additions & 2 deletions test/hotspot/jtreg/ProblemList.txt
Expand Up @@ -99,8 +99,8 @@ runtime/ReservedStack/ReservedStackTest.java 8231031 generic-all
# :hotspot_serviceability

serviceability/sa/ClhsdbDumpheap.java 8241158 macosx-x64
serviceability/sa/ClhsdbScanOops.java#id0 8241158,8230731 macosx-x64,windows-x64
serviceability/sa/ClhsdbScanOops.java#id1 8241158,8230731 macosx-x64,windows-x64
serviceability/sa/ClhsdbScanOops.java#id0 8241158 macosx-x64
serviceability/sa/ClhsdbScanOops.java#id1 8241158 macosx-x64
serviceability/sa/sadebugd/DebugdConnectTest.java 8239062 macosx-x64
serviceability/sa/TestHeapDumpForInvokeDynamic.java 8241158 macosx-x64
serviceability/sa/TestInstanceKlassSize.java 8230664 linux-ppc64le,linux-ppc64
Expand Down
2 changes: 1 addition & 1 deletion test/jdk/ProblemList.txt
Expand Up @@ -938,7 +938,7 @@ com/sun/jdi/InvokeHangTest.java 8218463 linux-al
# svc_tools

sun/tools/jhsdb/BasicLauncherTest.java 8211767 linux-ppc64,linux-ppc64le
sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java 8231634,8230731,8001227 generic-all,windows-all
sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java 8231634,8242787 generic-all


############################################################################
Expand Down

0 comments on commit c6c1f9b

Please sign in to comment.