Skip to content

Commit

Permalink
8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_d…
Browse files Browse the repository at this point in the history 
…estination

Reviewed-by: dlong, thartmann
  • Loading branch information
@shipilev
shipilev committed Jan 8, 2024
1 parent a40d397 commit eb9e754
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/hotspot/share/code/compiledIC.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,13 @@ void CompiledIC::internal_set_ic_destination(address entry_point, bool is_icstub
tty->cr();
}

#ifdef ASSERT
{
CodeBlob* cb = CodeCache::find_blob(_call->instruction_address());
assert(cb != nullptr && cb->is_compiled(), "must be compiled");
_call->set_destination_mt_safe(entry_point);
}
#endif
_call->set_destination_mt_safe(entry_point);

if (is_optimized() || is_icstub) {
// Optimized call sites don't have a cache value and ICStub call
Expand Down

7 comments on commit eb9e754

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@shipilev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@shipilev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on eb9e754 Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shipilev the backport was successfully created on the branch backport-shipilev-eb9e754b in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit eb9e754b from the openjdk/jdk repository.

The commit being backported was authored by Aleksey Shipilev on 8 Jan 2024 and was reviewed by Dean Long and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-shipilev-eb9e754b:backport-shipilev-eb9e754b
$ git checkout backport-shipilev-eb9e754b
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-shipilev-eb9e754b

@shipilev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on eb9e754 Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shipilev the backport was successfully created on the branch backport-shipilev-eb9e754b in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit eb9e754b from the openjdk/jdk repository.

The commit being backported was authored by Aleksey Shipilev on 8 Jan 2024 and was reviewed by Dean Long and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-shipilev-eb9e754b:backport-shipilev-eb9e754b
$ git checkout backport-shipilev-eb9e754b
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-shipilev-eb9e754b

@openjdk
Copy link

@openjdk openjdk bot commented on eb9e754 Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shipilev the backport was successfully created on the branch backport-shipilev-eb9e754b in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit eb9e754b from the openjdk/jdk repository.

The commit being backported was authored by Aleksey Shipilev on 8 Jan 2024 and was reviewed by Dean Long and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-shipilev-eb9e754b:backport-shipilev-eb9e754b
$ git checkout backport-shipilev-eb9e754b
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-shipilev-eb9e754b

Please sign in to comment.