8294920: Missing SP value in Linux x86_32 thread context

shipilev · shipilev · commit fe7a4617fec4 · 2022-10-07T18:23:16.000Z
Reviewed-by: cjplummer, sspitsyn
diff --git a/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/linux_x86/LinuxX86JavaThreadPDAccess.java b/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/linux_x86/LinuxX86JavaThreadPDAccess.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2002, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -116,7 +116,7 @@ public    void printInfoOn(Address threadAddr, PrintStream tty) {
   public    Address getLastSP(Address addr) {
     ThreadProxy t = getThreadProxy(addr);
     X86ThreadContext context = (X86ThreadContext) t.getContext();
-    return context.getRegisterAsAddress(X86ThreadContext.ESP);
+    return context.getRegisterAsAddress(X86ThreadContext.SP);
   }
 
   public    ThreadProxy getThreadProxy(Address addr) {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.`
	`2`	`+ * Copyright (c) 2002, 2022, Oracle and/or its affiliates. All rights reserved.`
`3`	`3`	`* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.`
`4`	`4`	`*`
`5`	`5`	`* This code is free software; you can redistribute it and/or modify it`
`@@ -116,7 +116,7 @@ public void printInfoOn(Address threadAddr, PrintStream tty) {`
`116`	`116`	`public Address getLastSP(Address addr) {`
`117`	`117`	`ThreadProxy t = getThreadProxy(addr);`
`118`	`118`	`X86ThreadContext context = (X86ThreadContext) t.getContext();`
`119`		`- return context.getRegisterAsAddress(X86ThreadContext.ESP);`
	`119`	`+ return context.getRegisterAsAddress(X86ThreadContext.SP);`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`public ThreadProxy getThreadProxy(Address addr) {`