Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293065: Zero build failure on AArch64 and RISCV64 after JDK-8293007 #10075

Closed

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Aug 30, 2022

JDK-8293007 changes the AARCH64_PORT_ONLY macro into AARCH64, which is not an equivalent replacement.
This patch also fixes the same zero build failure on RISCV64.

Testing:

  • Linux AArch64 zero release build
  • Linux AArch64 server release build
  • Linux RISCV64 zero release build
  • Linux RISCV64 server release build

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293065: Zero build failure on AArch64 and RISCV64 after JDK-8293007

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10075/head:pull/10075
$ git checkout pull/10075

Update a local copy of the PR:
$ git checkout pull/10075
$ git pull https://git.openjdk.org/jdk pull/10075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10075

View PR using the GUI difftool:
$ git pr show -t 10075

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10075.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2022

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@feilongjiang The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 30, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2022

Webrevs

Copy link
Contributor

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293065: Zero build failure on AArch64 and RISCV64 after JDK-8293007

Reviewed-by: eosterlund, fyang, yadongwang, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • c3380c0: 8292995: improve the SA page cache
  • 1cf245d: 8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag
  • 6335150: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified
  • 622be79: 8293090: Remove unused par_oop_since_save_marks_iterate_done
  • 3d0ab2b: 8292858: G1: Remove redundant check in G1FlushHumongousCandidateRemSets
  • 6e24827: 8292878: x86: Make scratch register usage explicit in assembler code
  • f5ebbf3: 8292657: Calling GetLocalXXX from virtual thread with thread parameter set to NULL returns carrier locals
  • 550e5d7: 4958071: (spec) confusing exception list for javax.crypto.Cipher.init(...) for
  • d3d2e66: 8293009: Remove unused field 'millisPerHour' in DateFormatSymbols
  • f3ebb42: 8293036: x86_64: Move Continuation-related stub methods to MacroAssembler
  • ... and 10 more: https://git.openjdk.org/jdk/compare/e016363b54f1624e9ff4470803c6000d8fe91a7f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fisk, @RealFYang, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 30, 2022
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Copy link
Contributor

@yadongw yadongw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm(not a reviewer)

@feilongjiang
Copy link
Member Author

@fisk @RealFYang @yadongw @vnkozlov -- Thanks!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@feilongjiang
Your change (at version d9d151d) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

Going to push as commit 2d7792c.
Since your change was applied there have been 20 commits pushed to the master branch:

  • c3380c0: 8292995: improve the SA page cache
  • 1cf245d: 8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag
  • 6335150: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified
  • 622be79: 8293090: Remove unused par_oop_since_save_marks_iterate_done
  • 3d0ab2b: 8292858: G1: Remove redundant check in G1FlushHumongousCandidateRemSets
  • 6e24827: 8292878: x86: Make scratch register usage explicit in assembler code
  • f5ebbf3: 8292657: Calling GetLocalXXX from virtual thread with thread parameter set to NULL returns carrier locals
  • 550e5d7: 4958071: (spec) confusing exception list for javax.crypto.Cipher.init(...) for
  • d3d2e66: 8293009: Remove unused field 'millisPerHour' in DateFormatSymbols
  • f3ebb42: 8293036: x86_64: Move Continuation-related stub methods to MacroAssembler
  • ... and 10 more: https://git.openjdk.org/jdk/compare/e016363b54f1624e9ff4470803c6000d8fe91a7f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2022
@openjdk openjdk bot closed this Aug 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@RealFYang @feilongjiang Pushed as commit 2d7792c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the fix-zero-build-rv-arm64 branch September 6, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
5 participants