8294038: Remove "Classpath" exception from javax/swing tests

[aivanov-jdk]

Remove the "Classpath" exception from tests in javax/swing. The tests should not have it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294038: Remove "Classpath" exception from javax/swing tests

Reviewers

• Dmitry Markov (@dmarkov20 - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10360/head:pull/10360
$ git checkout pull/10360

Update a local copy of the PR:
$ git checkout pull/10360
$ git pull https://git.openjdk.org/jdk pull/10360/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10360

View PR using the GUI difftool:
$ git pr show -t 10360

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10360.diff

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (95622492)

[scientificware]

Is there an official Copyright License Header for test codes.
Adding @author tag is not allowed but what's about copyright mention ?

[aivanov-jdk]

Is there an official Copyright License Header for test codes.

For new files, you usually take the copyright comment from a file nearby. All tests should use GPLv2 without the "Classpath" exception. The source code in src directory has the "Classpath" exception.

Adding @author tag is not allowed

Here's a quote from the jtreg tag spec: “Use of this tag is now generally discouraged; information about the author and other contributions is generally better left to the source code management system for the test suite.”

With Git, your name will be associated with the commit, thus all the code you contribute, unless modified, will be attributed to you without the use of the @author tag.

…but what's about copyright mention ?

You contribute the code under the OCA, “This agreement gives Oracle and you as a contributor joint copyright interests in the code. You will retain your copyright while also granting those rights to Oracle.”

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294038: Remove "Classpath" exception from javax/swing tests

Reviewed-by: dmarkov, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• e195897: 8294068: Unconditional and eager load of nio library since JDK-8264744
• 84d7ff6: 8288129: Shenandoah: Skynet test crashed with iu + aggressive
• 07afa3f: 8294110: compiler/uncommontrap/Decompile.java fails after JDK-8293798
• 0746bcb: 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers
• 95ec2ea: 8293897: Synthetic final modifier is part of the AST for a try-with-resource resource
• d14e96d: 8293493: Signal Handlers printout should show signal block state
• da4fdfb: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details
• cd1cdcd: 8293116: Incremental JDK build could be sped up
• e9401e6: 8293364: IGV: Refactor Action in EditorTopComponent and fix minor bugs
• 844a95b: 8292892: Javadoc index descriptions are not deterministic
• ... and 16 more: https://git.openjdk.org/jdk/compare/bb422f5c14745bf29bc2cb741f819a17c8400543...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[irisclark]

The updated license appears to match the GPL header (https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-header) as expected.

Thanks!

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit 27b8e2f.
Since your change was applied there have been 26 commits pushed to the master branch:

• e195897: 8294068: Unconditional and eager load of nio library since JDK-8264744
• 84d7ff6: 8288129: Shenandoah: Skynet test crashed with iu + aggressive
• 07afa3f: 8294110: compiler/uncommontrap/Decompile.java fails after JDK-8293798
• 0746bcb: 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers
• 95ec2ea: 8293897: Synthetic final modifier is part of the AST for a try-with-resource resource
• d14e96d: 8293493: Signal Handlers printout should show signal block state
• da4fdfb: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details
• cd1cdcd: 8293116: Incremental JDK build could be sped up
• e9401e6: 8293364: IGV: Refactor Action in EditorTopComponent and fix minor bugs
• 844a95b: 8292892: Javadoc index descriptions are not deterministic
• ... and 16 more: https://git.openjdk.org/jdk/compare/bb422f5c14745bf29bc2cb741f819a17c8400543...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit 27b8e2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.