8294466: Minimize disabled warnings in java.desktop #10453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
openjdk
bot
added
build
3 tasks
|
@magicus this pull request can not be integrated into git checkout java.desktop-warnings-per-file
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
openjdk
bot
added
the
merge-conflict
…ly due to unstable /proc/cpuinfo output Reviewed-by: alanb, shade, lancea
Reviewed-by: chegar, vtewari, dfuchs, jpai
…:getAll Reviewed-by: dfuchs
Co-authored-by: zifeihan <caogui@iscas.ac.cn> Reviewed-by: fyang, shade
Reviewed-by: tschatzl, kbarrett
…ionTask Reviewed-by: kbarrett, tschatzl
…al cgroup fs mounts Reviewed-by: iklam
Reviewed-by: darcy
Reviewed-by: jjg
Reviewed-by: naoto, coffeys
Reviewed-by: mgronlun
Reviewed-by: rehn, dholmes
Reviewed-by: dfuchs
Reviewed-by: mgronlun
Reviewed-by: dfuchs
Reviewed-by: lancea, bpb, naoto
Reviewed-by: mgronlun
Reviewed-by: thartmann, kvn
…tStream Reviewed-by: iris
Reviewed-by: alanb, bpb
Reviewed-by: kvn, dlong
Reviewed-by: dfuchs, alanb
…ress field Reviewed-by: never
Reviewed-by: sadayapalam, darcy, vromero
Reviewed-by: dholmes, kbarrett
…4 and riscv Reviewed-by: fyang, haosun
…roAssembler Reviewed-by: aph, tschatzl
Reviewed-by: yadongwang, fyang
…Prime and BigInteger::nextProblablePrime Reviewed-by: darcy, bpb
…hortcuts Reviewed-by: jiefu
Reviewed-by: mullan
…Nimbus LaF. Reviewed-by: jdv
…e performed earlier, at URL construction Reviewed-by: jpai, michaelm
Reviewed-by: stuefe, luhenry, fyang
Reviewed-by: shade, tschatzl
Reviewed-by: stuefe
Reviewed-by: tschatzl, shade
…hen file opened for append not specified Reviewed-by: alanb
Co-authored-by: Andrey Turbanov <aturbanov@openjdk.org> Reviewed-by: aturbanov, prr
Co-authored-by: Chris Plummer <cjplummer@openjdk.org> Reviewed-by: dnsimon, dcubed
Reviewed-by: iklam, ccheung, gziemski
Reviewed-by: naoto, bpb, lancea
Reviewed-by: mgronlun
openjdk
bot
removed
the
merge-conflict
|
I fouled up with the merge, and this PR got just messy. I'll close this and open a new. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After JDK-8294281, it is now possible to disable warnings for individual files instead for whole libraries. I used this opportunity to go through all disabled warnings in java.desktop native libraries.
Any warnings that were only triggered in a few files were removed from the library as a whole, and changed to be only disabled for those files.
Some warnings didn't trigger in any file anymore, and could just be removed.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10453/head:pull/10453$ git checkout pull/10453Update a local copy of the PR:
$ git checkout pull/10453$ git pull https://git.openjdk.org/jdk pull/10453/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10453View PR using the GUI difftool:
$ git pr show -t 10453Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10453.diff