8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread

[sspitsyn]

The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require the target thread to be suspended. If not suspended then the JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the implementation.

The CSR is: https://bugs.openjdk.org/browse/JDK-8294690

A few tests are impacted by this fix:

 test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest
 test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest
 test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t011

The following test has been removed as non-relevant any more:
test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java

New negative test has been added instead:
test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetSetLocalUnsuspended.java

All JVM TI and JPDA tests were used locally for verification.
They were also run in Loom repository with JTREG_MAIN_WRAPPER=Virtual.

Mach5 test runs on all platforms are TBD.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
• JDK-8294690: GetLocalXXX/SetLocalXXX spec should require suspending target thread (CSR)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer) ⚠️ Review applies to 5991659f
• Dmitry Samersoff (@dsamersoff - Reviewer) ⚠️ Review applies to 5991659f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10586/head:pull/10586
$ git checkout pull/10586

Update a local copy of the PR:
$ git checkout pull/10586
$ git pull https://git.openjdk.org/jdk pull/10586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10586

View PR using the GUI difftool:
$ git pr show -t 10586

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10586.diff

[bridgekeeper]

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sspitsyn The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (6d41ced5)
• 01: Full - Incremental (5991659f)
• 00: Full (b2c341f1)

[sspitsyn]

PING: Could someone review the CSR, please?

[AlanBateman]

PING: Could someone review the CSR, please?

I reviewed it yesterday.

[sspitsyn]

Thank you, Alan!
I did not refresh my browser, an so, did not see your review.

[mlbridge]

Mailing list message from Dmitry Samersoff on hotspot-dev:

Hi Serguei,

Looks good for me. Thank you!

-Dmitry

On 06/10/2022 20:31, Serguei Spitsyn wrote:

--
Dmitry.Samersoff at bell-sw.com
Technical Professional at BellSoft

[mlbridge]

Mailing list message from Serguei Spitsyn on hotspot-dev:

Hi Dmitry,

Do you have any plans to full review and approve this PR?
Thanks,
Serguei

From: hotspot-dev <hotspot-dev-retn at openjdk.org> on behalf of Dmitry Samersoff <dmitry.samersoff at bell-sw.com>
Date: Friday, October 7, 2022 at 1:34 AM
To: Serguei Spitsyn <sspitsyn at openjdk.org>, hotspot-dev at openjdk.org <hotspot-dev at openjdk.org>, serviceability-dev at openjdk.org <serviceability-dev at openjdk.org>
Subject: Re: RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v2]
Hi Serguei,

Looks good for me. Thank you!

-Dmitry

On 06/10/2022 20:31, Serguei Spitsyn wrote:

--
Dmitry.Samersoff at bell-sw.com
Technical Professional at BellSoft
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-dev/attachments/20221007/7014f4f2/attachment.htm>

[sspitsyn]

Leonid and Dmitry, thank you for review!

[openjdk]

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread

Reviewed-by: lmesnik, dsamersoff

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 144 new commits pushed to the master branch:

• f300ec8: 8294546: document where javac differs when invoked via launcher and ToolProvider
• b269c51: 8295395: Linux Alpha Zero builds fail after JDK-8292591
• ae60599: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
• 4d37ef2: 8295262: Build binutils out of source tree
• 0919a3a: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
• ec2981b: 8293711: Factor out size parsing functions from arguments.cpp
• 5d273b9: 8295278: Add parallel class loading tests
• 172006c: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
• 7743345: 8294314: Minimize disabled warnings in hotspot
• 552d8a2: 8295192: Use original configure command line when called from a script
• ... and 134 more: https://git.openjdk.org/jdk/compare/0ec18382b74396eec0681f2fdf0dac40f8fe108b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

/integrate

[openjdk]

Going to push as commit 21a825e.
Since your change was applied there have been 145 commits pushed to the master branch:

• 8d751de: 8295231: Move all linking of native libraries to make
• f300ec8: 8294546: document where javac differs when invoked via launcher and ToolProvider
• b269c51: 8295395: Linux Alpha Zero builds fail after JDK-8292591
• ae60599: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
• 4d37ef2: 8295262: Build binutils out of source tree
• 0919a3a: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
• ec2981b: 8293711: Factor out size parsing functions from arguments.cpp
• 5d273b9: 8295278: Add parallel class loading tests
• 172006c: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
• 7743345: 8294314: Minimize disabled warnings in hotspot
• ... and 135 more: https://git.openjdk.org/jdk/compare/0ec18382b74396eec0681f2fdf0dac40f8fe108b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn Pushed as commit 21a825e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.