New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255214: Unsupported 'valign' attribute for 'th' tag used in j.u.l.LogManager #1064
Conversation
👋 Welcome back ryadav! A progress list of the required criteria for merging this PR into |
@rhyadav Syntax:
|
@rhyadav Syntax:
|
@rhyadav Could not parse
|
/reviewer credit @dfuch |
@rhyadav |
@rhyadav This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@rhyadav |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Rahul. The generated javadoc looks OK too.
/issue JDK-8255214 |
@rhyadav This issue is referenced in the PR title - it will now be updated. |
@rhyadav Since your change was applied there have been 15 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 867a484. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@rhyadav The command |
Hello,
Request to review this small change, as HTML4 support has been dropped from javadoc.
Have replaced valign="top" with style="vertical-align:top".
Progress
Testing
Failed test tasks
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1064/head:pull/1064
$ git checkout pull/1064