-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295774: Write a test to verify List sends ItemEvent/ActionEvent #10899
Conversation
Hi @ravigupta30, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ravigupta30" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
@ravigupta30 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
/covered Oracle employee |
Webrevs
|
|
@ravigupta30 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 51 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @aivanov-jdk) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@ravigupta30, I edited the JBS subject, you have to update the subject of the PR here. |
/integrate |
@ravigupta30 |
can someone sponsor. |
/sponsor |
Going to push as commit 2a79dfc.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk @ravigupta30 Pushed as commit 2a79dfc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mailing list message from Patrick Chen on client-libs-dev: agree Le mer. 2 nov. 2022 ? 16:10, Alexey Ivanov <aivanov at openjdk.org> a ?crit : -------------- next part -------------- |
This testcase verify that List Item selection via mouse/keys generates ItemEvent/ActionEvent appropriately.
a. Single click on the list generate ItemEvent and double click on item generates ActionEvent.
b. UP/DOWN keys on the list generate ItemEvent and enter key on item generates ActionEvent.
Testing:
Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10899/head:pull/10899
$ git checkout pull/10899
Update a local copy of the PR:
$ git checkout pull/10899
$ git pull https://git.openjdk.org/jdk pull/10899/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10899
View PR using the GUI difftool:
$ git pr show -t 10899
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10899.diff