8295774: Write a test to verify List sends ItemEvent/ActionEvent #10899

ravigupta30 · 2022-10-28T09:01:53Z

This testcase verify that List Item selection via mouse/keys generates ItemEvent/ActionEvent appropriately.

a. Single click on the list generate ItemEvent and double click on item generates ActionEvent.
b. UP/DOWN keys on the list generate ItemEvent and enter key on item generates ActionEvent.

Testing:
Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8295774: Write a test to verify List sends ItemEvent/ActionEvent

Reviewers

Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to c4cf5168
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10899/head:pull/10899
$ git checkout pull/10899

Update a local copy of the PR:
$ git checkout pull/10899
$ git pull https://git.openjdk.org/jdk pull/10899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10899

View PR using the GUI difftool:
$ git pr show -t 10899

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10899.diff

bridgekeeper · 2022-10-28T09:03:23Z

Hi @ravigupta30, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ravigupta30" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

openjdk · 2022-10-28T09:06:04Z

@ravigupta30 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

ravigupta30 · 2022-10-28T09:11:43Z

/covered

bridgekeeper · 2022-10-28T09:12:33Z

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

ravigupta30 · 2022-10-28T09:44:45Z

/covered Oracle employee

mlbridge · 2022-10-28T10:33:58Z

Webrevs

openjdk · 2022-10-29T23:15:13Z

⚠️ @ravigupta30 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8295774
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

openjdk · 2022-10-29T23:15:16Z

@ravigupta30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295774: Write a test to verify List sends ItemEvent/ActionEvent

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

d771abb: 8295970: Add vector api sanity tests in tier1
7a85441: 8232933: Javac inferred type does not conform to equality constraint
6ee8ccf: 8296168: x86: Add reasonable constraints between AVX and SSE
1950747: 8279913: obsolete ExtendedDTraceProbes
13b20e0: 8296262: Remove dead code from InstanceKlass::signature_name()
fd60036: 8296188: Update style and header in JDWP Protocol spec and JVMTI spec
c7b95a8: 8296163: [aarch64] Cleanup Pre/Post addressing mode classes
f84b0ad: 8295670: Remove duplication in java/util/Formatter/Basic*.java
a124d8e: 8296115: Allow for compiling the JDK with strict standards conformance
491d43c: 8289838: ZGC: OOM before clearing all SoftReferences
... and 41 more: https://git.openjdk.org/jdk/compare/4b89fce0831f990d4b6af5e6e208342f68aed614...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

test/jdk/java/awt/event/ComponentEvent/ListItemEventsTest.java

aivanov-jdk · 2022-11-02T14:30:42Z

@ravigupta30, I edited the JBS subject, you have to update the subject of the PR here.

test/jdk/java/awt/event/ComponentEvent/ListItemEventsTest.java

ravigupta30 · 2022-11-03T08:48:05Z

/integrate

openjdk · 2022-11-03T12:12:00Z

@ravigupta30
Your change (at version 305b012) is now ready to be sponsored by a Committer.

ravigupta30 · 2022-11-03T12:22:47Z

can someone sponsor.

aivanov-jdk · 2022-11-03T13:37:29Z

/sponsor

openjdk · 2022-11-03T13:39:17Z

Going to push as commit 2a79dfc.
Since your change was applied there have been 52 commits pushed to the master branch:

cc3c5a1: 8296101: nmethod::is_unloading result unstable with concurrent unloading
d771abb: 8295970: Add vector api sanity tests in tier1
7a85441: 8232933: Javac inferred type does not conform to equality constraint
6ee8ccf: 8296168: x86: Add reasonable constraints between AVX and SSE
1950747: 8279913: obsolete ExtendedDTraceProbes
13b20e0: 8296262: Remove dead code from InstanceKlass::signature_name()
fd60036: 8296188: Update style and header in JDWP Protocol spec and JVMTI spec
c7b95a8: 8296163: [aarch64] Cleanup Pre/Post addressing mode classes
f84b0ad: 8295670: Remove duplication in java/util/Formatter/Basic*.java
a124d8e: 8296115: Allow for compiling the JDK with strict standards conformance
... and 42 more: https://git.openjdk.org/jdk/compare/4b89fce0831f990d4b6af5e6e208342f68aed614...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-03T13:39:35Z

@aivanov-jdk @ravigupta30 Pushed as commit 2a79dfc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mlbridge · 2022-11-09T19:56:58Z

Mailing list message from Patrick Chen on client-libs-dev:

agree

Le mer. 2 nov. 2022 ? 16:10, Alexey Ivanov <aivanov at openjdk.org> a ?crit :

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20221102/2291a7ca/attachment.htm>

8295774 : Write a test to verify that List Item selection events.

c4cf516

bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 28, 2022

openjdk bot added the client client-libs-dev@openjdk.org label Oct 28, 2022

bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 28, 2022

bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 28, 2022

openjdk bot added the rfr Pull request is ready for review label Oct 28, 2022

mrserb approved these changes Oct 29, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2022

aivanov-jdk suggested changes Oct 30, 2022

View reviewed changes

8295774 : Write a test to verify that List Item selection events.

984ab23

openjdk bot removed the ready Pull request is ready to be integrated label Nov 2, 2022

aivanov-jdk suggested changes Nov 2, 2022

View reviewed changes

8295774: Write a test to verify that List Item selection events.

69296bb

openjdk bot removed the rfr Pull request is ready for review label Nov 2, 2022

aivanov-jdk suggested changes Nov 2, 2022

View reviewed changes

test/jdk/java/awt/event/ComponentEvent/ListItemEventsTest.java Outdated Show resolved Hide resolved

8295774: Write a test to verify that List Item selection events.

814c339

openjdk bot added the rfr Pull request is ready for review label Nov 2, 2022

aivanov-jdk reviewed Nov 2, 2022

View reviewed changes

test/jdk/java/awt/event/ComponentEvent/ListItemEventsTest.java Outdated Show resolved Hide resolved

aivanov-jdk approved these changes Nov 2, 2022

View reviewed changes

ravigupta30 changed the title ~~8295774 : Write a test to verify that List Item selection events.~~ 8295774: Write a test to verify List sends ItemEvent/ActionEvent Nov 2, 2022

openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2022

8295774: Write a test to verify List sends ItemEvent/ActionEvent

305b012

aivanov-jdk approved these changes Nov 3, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 3, 2022

openjdk bot added the integrated Pull request has been integrated label Nov 3, 2022

openjdk bot closed this Nov 3, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8295774: Write a test to verify List sends ItemEvent/ActionEvent #10899

8295774: Write a test to verify List sends ItemEvent/ActionEvent #10899

ravigupta30 commented Oct 28, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Oct 28, 2022

openjdk bot commented Oct 28, 2022

ravigupta30 commented Oct 28, 2022

bridgekeeper bot commented Oct 28, 2022

ravigupta30 commented Oct 28, 2022

mlbridge bot commented Oct 28, 2022 •

edited

Loading

openjdk bot commented Oct 29, 2022

openjdk bot commented Oct 29, 2022 •

edited

Loading

aivanov-jdk commented Nov 2, 2022

ravigupta30 commented Nov 3, 2022

openjdk bot commented Nov 3, 2022

ravigupta30 commented Nov 3, 2022

aivanov-jdk commented Nov 3, 2022

openjdk bot commented Nov 3, 2022

openjdk bot commented Nov 3, 2022

mlbridge bot commented Nov 9, 2022

8295774: Write a test to verify List sends ItemEvent/ActionEvent #10899

8295774: Write a test to verify List sends ItemEvent/ActionEvent #10899

Conversation

ravigupta30 commented Oct 28, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Oct 28, 2022

openjdk bot commented Oct 28, 2022

ravigupta30 commented Oct 28, 2022

bridgekeeper bot commented Oct 28, 2022

ravigupta30 commented Oct 28, 2022

mlbridge bot commented Oct 28, 2022 • edited Loading

Webrevs

openjdk bot commented Oct 29, 2022

openjdk bot commented Oct 29, 2022 • edited Loading

aivanov-jdk commented Nov 2, 2022

ravigupta30 commented Nov 3, 2022

openjdk bot commented Nov 3, 2022

ravigupta30 commented Nov 3, 2022

aivanov-jdk commented Nov 3, 2022

openjdk bot commented Nov 3, 2022

openjdk bot commented Nov 3, 2022

mlbridge bot commented Nov 9, 2022

ravigupta30 commented Oct 28, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 28, 2022 •

edited

Loading

openjdk bot commented Oct 29, 2022 •

edited

Loading