Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8255984: Shenandoah: "adaptive" heuristic is prone to missing load spikes #1099

Closed
wants to merge 20 commits into from
Closed

8255984: Shenandoah: "adaptive" heuristic is prone to missing load spikes #1099

wants to merge 20 commits into from

Commits on Nov 5, 2020

  1. Add a "reactive" heuristic for triggering concurrent GC cycles 

    The reactive heuristic maintains a margin of error and a spike
detection mechanism to trigger cycles somewhat more aggressively
than the 'adaptive' heuristic. This heuristic 'reacts' to the
outcome of GC cycles by adjusting the sensitivity of the triggers.
    @earthling-amzn
    earthling-amzn committed Nov 5, 2020
    Copy the full SHA
    b6bc703 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Incorporate review feed back 

     - Remove unnecessary log level checks
 - More idiomatic style
    @earthling-amzn
    earthling-amzn committed Nov 10, 2020
    Copy the full SHA
    2efc73c View commit details
    Browse the repository at this point in the history

  2. Merge 'reactive' heuristic into 'adaptive' heuristic

    @earthling-amzn
    earthling-amzn committed Nov 10, 2020
    Copy the full SHA
    7f1de19 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Rename ShenandoahReactive flags to ShenandoahAdaptive flags.

    @earthling-amzn
    earthling-amzn committed Nov 12, 2020
    Copy the full SHA
    66dd531 View commit details
    Browse the repository at this point in the history

  2. Remove const qualifier from should_start_gc 

    This lets the heuristics update state without const_casts.
    @earthling-amzn
    earthling-amzn committed Nov 12, 2020
    Copy the full SHA
    275e80a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Restore call to reset allocation counter at cycle start

    @earthling-amzn
    earthling-amzn committed Nov 13, 2020
    Copy the full SHA
    8b2528a View commit details
    Browse the repository at this point in the history

  2. Make logging messages more consistent

    @earthling-amzn
    earthling-amzn committed Nov 13, 2020
    Copy the full SHA
    8e204f4 View commit details
    Browse the repository at this point in the history

  3. Rename variables to improve readability

    @earthling-amzn
    earthling-amzn committed Nov 13, 2020
    Copy the full SHA
    ec99e2d View commit details
    Browse the repository at this point in the history

  4. Reuse instantaneous_rate method instead of duplicating code

    @earthling-amzn
    earthling-amzn committed Nov 13, 2020
    Copy the full SHA
    5d0512a View commit details
    Browse the repository at this point in the history

  5. Use os::elapsedTime to avoid type issues and to be consistent with ot… 

    …her heuristics code
    @earthling-amzn
    earthling-amzn committed Nov 13, 2020
    Copy the full SHA
    98d459b View commit details
    Browse the repository at this point in the history

  6. Inline calls to gc decision methods (vestige of an earlier design)

    @earthling-amzn
    earthling-amzn committed Nov 13, 2020
    Copy the full SHA
    6ef8dc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Defend against underflow and division by zero

    @earthling-amzn
    earthling-amzn committed Nov 16, 2020
    Copy the full SHA
    543afbb View commit details
    Browse the repository at this point in the history

  2. Remove dependency from allocation rate to adaptive heuristic

    @earthling-amzn
    earthling-amzn committed Nov 16, 2020
    Copy the full SHA
    3ec8f3c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Fix wrong type for os::elapsedTime

    @earthling-amzn
    earthling-amzn committed Nov 17, 2020
    Copy the full SHA
    f6bb039 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into shenandoah-reactive-heuristic

    @earthling-amzn
    earthling-amzn committed Nov 17, 2020
    Copy the full SHA
    02f5c2d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Avoid recomputing instantaneous allocation rate

    @earthling-amzn
    earthling-amzn committed Nov 19, 2020
    Copy the full SHA
    85c32e4 View commit details
    Browse the repository at this point in the history

  2. Remove unused member

    @earthling-amzn
    earthling-amzn committed Nov 19, 2020
    Copy the full SHA
    68ba628 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Sample allocation rate even if cumulative bytes allocated hasn't changed 

    Without this, the average allocation rate will be much higher than it should be.
    @earthling-amzn
    earthling-amzn committed Nov 20, 2020
    Copy the full SHA
    45c0f51 View commit details
    Browse the repository at this point in the history

  2. Do not re-sample allocation rate with higher frequency 

    This causes too many false positives and triggers unnecessary cycles.
    @earthling-amzn
    earthling-amzn committed Nov 20, 2020
    Copy the full SHA
    8b58ec8 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Factor rate check into is_spiking

    @earthling-amzn
    earthling-amzn committed Nov 23, 2020
    Copy the full SHA
    72f15a6 View commit details
    Browse the repository at this point in the history