-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 #11120
Conversation
/label client |
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
@prrace |
Webrevs
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit c71d87e.
Your commit was automatically rebased without conflicts. |
This was a closed test - simply because it hadn't been reviewed for moving to open
so I am doing it now whilst fixing a problem that was observed on the OL 8.x (and
by implication an RHEL 8.x) desktop due to the screen menu bar rendering over one
line of the undecorated window.
That was fixed by changing the location to use setLocationRelativeTo(null) vs
the previous implied (0,0)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11120/head:pull/11120
$ git checkout pull/11120
Update a local copy of the PR:
$ git checkout pull/11120
$ git pull https://git.openjdk.org/jdk pull/11120/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11120
View PR using the GUI difftool:
$ git pr show -t 11120
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11120.diff