Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 #11120

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Nov 12, 2022

This was a closed test - simply because it hadn't been reviewed for moving to open
so I am doing it now whilst fixing a problem that was observed on the OL 8.x (and
by implication an RHEL 8.x) desktop due to the screen menu bar rendering over one
line of the undecorated window.
That was fixed by changing the location to use setLocationRelativeTo(null) vs
the previous implied (0,0)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11120/head:pull/11120
$ git checkout pull/11120

Update a local copy of the PR:
$ git checkout pull/11120
$ git pull https://git.openjdk.org/jdk pull/11120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11120

View PR using the GUI difftool:
$ git pr show -t 11120

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11120.diff

@prrace
Copy link
Contributor Author

prrace commented Nov 12, 2022

/label client

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2022

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8286624 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Nov 12, 2022
@openjdk openjdk bot added rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Nov 12, 2022
@openjdk
Copy link

openjdk bot commented Nov 12, 2022

@prrace
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

Reviewed-by: azvegint, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
  • 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
  • 95b8405: 8296431: PushbackInputStream should override transferTo
  • e269dc0: 8293681: ResponseAPDU getData() method javadoc
  • 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
  • 0fe2bf5: 8296805: ctw build is broken
  • e1d298c: 8296741: Illegal X400Address and EDIPartyName should not be created
  • b0edfc1: 8164464: Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java
  • 9c39932: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259
  • 3f401b3: 8296670: G1: Remove unused G1GCPhaseTimes::record_preserve_cm_referents_time_ms
  • ... and 5 more: https://git.openjdk.org/jdk/compare/657a0b2f1564e1754dbd64b776c53a52c480c901...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2022
@prrace
Copy link
Contributor Author

prrace commented Nov 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

Going to push as commit c71d87e.
Since your change was applied there have been 16 commits pushed to the master branch:

  • a7c2338: 8296900: CertificateValidity fields are not optional
  • 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
  • 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
  • 95b8405: 8296431: PushbackInputStream should override transferTo
  • e269dc0: 8293681: ResponseAPDU getData() method javadoc
  • 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
  • 0fe2bf5: 8296805: ctw build is broken
  • e1d298c: 8296741: Illegal X400Address and EDIPartyName should not be created
  • b0edfc1: 8164464: Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java
  • 9c39932: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259
  • ... and 6 more: https://git.openjdk.org/jdk/compare/657a0b2f1564e1754dbd64b776c53a52c480c901...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2022
@openjdk openjdk bot closed this Nov 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@prrace Pushed as commit c71d87e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants