8297794: Deprecate JMX Management Applets for Removal #11430

kevinjwalls · 2022-11-30T12:08:22Z

Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.

This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.

More details in bug, and CSR JDK-8297795

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires a CSR request to be approved

Issues

JDK-8297794: Deprecate JMX Management Applets for Removal
JDK-8297795: Deprecate JMX Management Applets for Removal (CSR)

Reviewers

Daniel Fuchs (@dfuch - Reviewer)
Sean Mullan (@seanjmullan - Reviewer)
Roger Riggs (@RogerRiggs - Reviewer)
Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11430/head:pull/11430
$ git checkout pull/11430

Update a local copy of the PR:
$ git checkout pull/11430
$ git pull https://git.openjdk.org/jdk pull/11430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11430

View PR using the GUI difftool:
$ git pr show -t 11430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11430.diff

bridgekeeper · 2022-11-30T12:09:44Z

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-30T12:11:50Z

@kevinjwalls The following labels will be automatically applied to this pull request:

jmx
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-30T13:22:20Z

Webrevs

AlanBateman · 2022-11-30T13:32:43Z

Are you planning to add the @deprecated tag with the description for why they are deprecated? I'm surprised the java.management module compiles without it but maybe this module has doclint config in its make file.

dfuch

I have the same remark as Alan - I believe an @deprecated text is needed in the API documentation of the public exported classes that are deprecated. At the minimum something like:

* @deprecated This class is deprecated for removal. There is no replacement.

I also see that you have chosen to add @SuppressWarnings in tests. Not sure what the rules are for the serviceability area - but usually it's fine to keep the deprecation warning in tests (that is: suppressing deprecation warnings in tests is usually optional).

src/java.management/share/classes/javax/management/loading/MLetObjectInputStream.java

src/java.management/share/classes/javax/management/loading/MLetParser.java

kevinjwalls · 2022-11-30T14:24:36Z

Thanks both, yes will add a doc comment also. Currently the generated docs give you: "Deprecated, for removal: This API element is subject to removal in a future version." But will add more around that.

MLetObjectInputStream and MLetParser are not public classes, so thinking they are not part of the public API we need to deprecate before removal.

Happy to try and avoid test logs being full of excess noise with those suppression annotations... 8-)

dfuch · 2022-11-30T14:42:08Z

MLetObjectInputStream and MLetParser are not public classes, so thinking they are not part of the public API we need to deprecate before removal.

Whether a class is public exported or not has no real relationship with whether it should have the @Deprecated annotation or not. It is better to add the @Deprecated annotation eagerly to all classes that are part of the feature being deprecated, if they are only used for the implementation of that feature, and if the thinking is that they would be removed if the feature is removed. Plus it usually simplifies things as it usually minimizes the places where you need to suppress warnings.

src/java.management/share/classes/javax/management/loading/MLet.java

kevinjwalls · 2022-11-30T16:58:36Z

Updated with additional Deprecated annotations on two non-public classes which would also be removed.
No deprecation tag doc update as there are no public API docs for these.

src/java.management/share/classes/javax/management/loading/MLetParser.java

kevinjwalls · 2022-12-01T12:37:04Z

Added release-note in a subtask for the issue.

dfuch

LGTM

openjdk · 2022-12-01T16:04:44Z

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297794: Deprecate JMX Management Applets for Removal

Reviewed-by: dfuchs, mullan, rriggs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

82561de: 8296384: [TESTBUG] sun/security/provider/SecureRandom/AbstractDrbg/SpecTest.java intermittently timeout
61b7093: 8297872: Non-local G1MonotonicArenaFreePool::_freelist_pool has non-trivial ctor/dtor
3b3bbe5: 8296907: VMError: add optional callstacks, siginfo for secondary errors
a573923: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
b49fd92: 8298055: AArch64: fastdebug build fails after JDK-8247645
914ef07: 8297609: Add application/wasm MIME type for wasm file extension
a71d91b: 8298067: Persistent test failures after 8296012
87572d4: 8298068: ProblemList tests failing due to JDK-8297235
0edb5d0: 8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss
c67166f: 8298003: NMT: fatal block printout does not show the correct corruption address
... and 70 more: https://git.openjdk.org/jdk/compare/b52611bc36d4fa7b62d1bb1618aa5185f75bf5d0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

RogerRiggs

LGTM

kevinjwalls · 2022-12-05T09:17:44Z

Thanks for all the reviews!

kevinjwalls · 2022-12-05T09:25:59Z

/integrate

openjdk · 2022-12-05T09:27:24Z

Going to push as commit 17666fb.
Since your change was applied there have been 81 commits pushed to the master branch:

619b68c: 8294540: Remove Opaque2Node: it is broken and triggers assert
82561de: 8296384: [TESTBUG] sun/security/provider/SecureRandom/AbstractDrbg/SpecTest.java intermittently timeout
61b7093: 8297872: Non-local G1MonotonicArenaFreePool::_freelist_pool has non-trivial ctor/dtor
3b3bbe5: 8296907: VMError: add optional callstacks, siginfo for secondary errors
a573923: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
b49fd92: 8298055: AArch64: fastdebug build fails after JDK-8247645
914ef07: 8297609: Add application/wasm MIME type for wasm file extension
a71d91b: 8298067: Persistent test failures after 8296012
87572d4: 8298068: ProblemList tests failing due to JDK-8297235
0edb5d0: 8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss
... and 71 more: https://git.openjdk.org/jdk/compare/b52611bc36d4fa7b62d1bb1618aa5185f75bf5d0...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-12-05T09:27:46Z

@kevinjwalls Pushed as commit 17666fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

kevinjwalls added 2 commits November 30, 2022 10:42

8297794: Deprecate JMX Management Applets for Removal

b76cfe8

Test updates

b82530a

openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org csr Pull request needs approved CSR before integration labels Nov 30, 2022

kevinjwalls marked this pull request as ready for review November 30, 2022 13:14

openjdk bot added the rfr Pull request is ready for review label Nov 30, 2022

dfuch reviewed Nov 30, 2022

View reviewed changes

src/java.management/share/classes/javax/management/loading/MLetObjectInputStream.java Show resolved Hide resolved

src/java.management/share/classes/javax/management/loading/MLetParser.java Show resolved Hide resolved

deprecated api doc text

55c7a18

RogerRiggs reviewed Nov 30, 2022

View reviewed changes

src/java.management/share/classes/javax/management/loading/MLet.java Show resolved Hide resolved

Deprecated annotation on the package-private classes

8fc74d5

dfuch reviewed Nov 30, 2022

View reviewed changes

src/java.management/share/classes/javax/management/loading/MLetParser.java Outdated Show resolved Hide resolved

unnecessary Suppression nit

eab7dc6

openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 30, 2022

dfuch approved these changes Dec 1, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2022

seanjmullan approved these changes Dec 2, 2022

View reviewed changes

RogerRiggs approved these changes Dec 2, 2022

View reviewed changes

AlanBateman approved these changes Dec 5, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Dec 5, 2022

openjdk bot closed this Dec 5, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8297794: Deprecate JMX Management Applets for Removal #11430

8297794: Deprecate JMX Management Applets for Removal #11430

kevinjwalls commented Nov 30, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 30, 2022

openjdk bot commented Nov 30, 2022

mlbridge bot commented Nov 30, 2022 •

edited

Loading

AlanBateman commented Nov 30, 2022

dfuch left a comment

kevinjwalls commented Nov 30, 2022

dfuch commented Nov 30, 2022 •

edited

Loading

kevinjwalls commented Nov 30, 2022

kevinjwalls commented Dec 1, 2022

dfuch left a comment

openjdk bot commented Dec 1, 2022 •

edited

Loading

RogerRiggs left a comment

kevinjwalls commented Dec 5, 2022

kevinjwalls commented Dec 5, 2022

openjdk bot commented Dec 5, 2022

openjdk bot commented Dec 5, 2022

8297794: Deprecate JMX Management Applets for Removal #11430

8297794: Deprecate JMX Management Applets for Removal #11430

Conversation

kevinjwalls commented Nov 30, 2022 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

bridgekeeper bot commented Nov 30, 2022

openjdk bot commented Nov 30, 2022

mlbridge bot commented Nov 30, 2022 • edited Loading

Webrevs

AlanBateman commented Nov 30, 2022

dfuch left a comment

Choose a reason for hiding this comment

kevinjwalls commented Nov 30, 2022

dfuch commented Nov 30, 2022 • edited Loading

kevinjwalls commented Nov 30, 2022

kevinjwalls commented Dec 1, 2022

dfuch left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 1, 2022 • edited Loading

RogerRiggs left a comment

Choose a reason for hiding this comment

kevinjwalls commented Dec 5, 2022

kevinjwalls commented Dec 5, 2022

openjdk bot commented Dec 5, 2022

openjdk bot commented Dec 5, 2022

kevinjwalls commented Nov 30, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 30, 2022 •

edited

Loading

dfuch commented Nov 30, 2022 •

edited

Loading

openjdk bot commented Dec 1, 2022 •

edited

Loading