8301637: ThreadLocalRandom.current().doubles().parallel() contention

[kabutz]

ThreadLocalRandom.current().doubles().parallel() had a bad regression, because it called the superclass methods of the ThreadLocalRandomProxy's nextDouble() method instead of delegating to the ThreadLocalRandom.current().

Affects all versions of ThreadLocalRandom since Java 17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301637: ThreadLocalRandom.current().doubles().parallel() contention

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12366/head:pull/12366
$ git checkout pull/12366

Update a local copy of the PR:
$ git checkout pull/12366
$ git pull https://git.openjdk.org/jdk pull/12366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12366

View PR using the GUI difftool:
$ git pr show -t 12366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12366.diff

[bridgekeeper]

👋 Welcome back kabutz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kabutz The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[AlanBateman]

/issue JDK-8301637

[openjdk]

@AlanBateman Only the author (@kabutz) is allowed to issue the /issue command.

[kabutz]

/issue JDK-8301637

[openjdk]

@kabutz This issue is referenced in the PR title - it will now be updated.

[mlbridge]

Webrevs

• 00: Full (054e4e76)

[kabutz]

Could this fix be back-ported to JDK 17? It's been an issue from then until now.

[jddarcy]

Could this fix be back-ported to JDK 17? It's been an issue from then until now.

Assuming the fix goes into mainline, there are procedures for backporting to the update releases; e.g.

https://wiki.openjdk.org/display/JDKUpdates/JDK+17u

[openjdk]

@kabutz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301637: ThreadLocalRandom.current().doubles().parallel() contention

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• af474ce: 8297582: C2: very slow compilation due to type system verification code
• 8d6e8a4: 8301618: Compare elements and type mirrors properly
• d683212: Merge
• 1330d4e: 8298377: JfrVframeStream causes deadlocks in ZGC
• 225f805: 8299891: JMX ObjectInputFilter additional classes needed
• 960c393: 8301393: Include cdb in the Windows devkit
• 6c927c9: 8301299: Wrong class spec on sun.security.util.Pem
• 51ac878: 8284236: Remove java/lang/ref/ReferenceEnqueue.java from ProblemList-Xcomp.txt
• 9952108: 8300811: jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL
• 24ff3da: 8301201: Allow \n@ inside inline tags using inlineContent
• ... and 1 more: https://git.openjdk.org/jdk/compare/bc750f70f2ac1f14f5b8e6236c593dcbe99cb12f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kabutz]

/integrate

[openjdk]

@kabutz
Your change (at version 054e4e7) is now ready to be sponsored by a Committer.

[kabutz]

Could someone please sponsor this change? @AlanBateman or @jddarcy ?

[amaembo]

/sponsor

[openjdk]

Going to push as commit cf6b9eb.
Since your change was applied there have been 34 commits pushed to the master branch:

• c647ae6: 8301149: Parallel: Refactor MutableNUMASpace::update_layout
• de57733: 8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811
• 930ec00: 8301636: Minor cleanup in CommentHelper and DocPretty
• 725d57b: 8301659: Resolve initialization reordering issues on Windows for libawt and libsaproc
• 2d50c7d: 8298979: Remove duplicated serviceability/jvmti/thread/GetAllThreads/allthr01/allthr01.java
• 59b7fb1: 8300273: [IR framework] Handle message instead of bailing out
• 5b1584b: 8298880: VectorLogicalOpIdentityTest.java IR test incorrectly use avx3 instead of avx512
• 21c1afb: 8301612: OopLoadProxy constructor should be explicit
• 03b23a1: 8301367: Add exception handler method to the BaseLdapServer
• 7b6ac41: 8286876: NMT.test_unaliged_block_address_vm_assert fails if using clang toolchain
• ... and 24 more: https://git.openjdk.org/jdk/compare/bc750f70f2ac1f14f5b8e6236c593dcbe99cb12f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@amaembo @kabutz Pushed as commit cf6b9eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.