Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256585: Remove in-place conversion vector operators from Vector API #1305

Closed
wants to merge 2 commits into from

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Nov 19, 2020

Remove partially implemented in-place conversion vector operators from Vector API:
ofNarrowing, ofWidening, INPLACE_XXX


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux aarch64 Linux arm Linux ppc64le Linux s390x Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (6/6 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ❌ (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8256585: Remove in-place conversion vector operators from Vector API

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1305/head:pull/1305
$ git checkout pull/1305

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2020

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2020

@sviswa7 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@sviswa7
Copy link
Author

sviswa7 commented Nov 19, 2020

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 19, 2020
@openjdk
Copy link

openjdk bot commented Nov 19, 2020

@sviswa7
The core-libs label was successfully added.

@sviswa7
Copy link
Author

sviswa7 commented Nov 19, 2020

/label hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 19, 2020
@openjdk
Copy link

openjdk bot commented Nov 19, 2020

@sviswa7
The hotspot label was successfully added.

@sviswa7 sviswa7 marked this pull request as ready for review November 19, 2020 04:01
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2020

Webrevs

@jddarcy
Copy link
Member

jddarcy commented Nov 19, 2020

/csr needed

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Nov 19, 2020
@openjdk
Copy link

openjdk bot commented Nov 19, 2020

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@sviswa7 please create a CSR request and add link to it in JDK-8256585. This pull request cannot be integrated until the CSR request is approved.

Copy link
Member

@PaulSandoz PaulSandoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation Vector.convert and Vector.convertShape needs to be updated to remove specification of in-place conversions, as does the class documentation on Vector. A search for the term in-place should find the relevant locations.

@sviswa7
Copy link
Author

sviswa7 commented Nov 19, 2020

Updated documentation to reflect removal of widening and contracting in-place conversions.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 23, 2020
@openjdk
Copy link

openjdk bot commented Nov 23, 2020

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256585: Remove in-place conversion vector operators from Vector API

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • e06a683: 8256497: Zero: enable G1 and Shenandoah GCs
  • 037e49c: 8256670: Zero: enable compressed oops support back
  • d46f6f5: 8256523: Streamline Java SHA2 implementation
  • 1aa90ac: 8256822: runtime/logging/RedefineClasses.java fails with "Error: VM option 'Verbose' is develop and is available only in debug version of VM."
  • edf72f0: 8256824: test/langtools/tools/javac/diags/examples/InnerClassCantHaveStatic.java has a bad copyright
  • 9a19eb6: 8254105: allow static nested declarations
  • 14de791: 8255934: JConsole 14 and greater fails to connect to older JVM
  • 86f3602: 8256806: Shenandoah: optimize shenandoah/jni/TestPinnedGarbage.java test
  • 57025e6: 8256073: Improve vector rematerialization support
  • 41c0587: 8255367: C2: Deoptimization during vector box construction is broken
  • ... and 52 more: https://git.openjdk.java.net/jdk/compare/2b15571316b983bd153722a91540343b8d4dfbc7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2020
@sviswa7
Copy link
Author

sviswa7 commented Nov 23, 2020

/integrate

@openjdk openjdk bot closed this Nov 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2020
@openjdk
Copy link

openjdk bot commented Nov 23, 2020

@sviswa7 Since your change was applied there have been 81 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9de5d09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants