New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256585: Remove in-place conversion vector operators from Vector API #1305
Conversation
👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into |
@sviswa7 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label core-libs |
@sviswa7 |
/label hotspot |
@sviswa7 |
Webrevs
|
/csr needed |
@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation Vector.convert
and Vector.convertShape
needs to be updated to remove specification of in-place conversions, as does the class documentation on Vector
. A search for the term in-place
should find the relevant locations.
Updated documentation to reflect removal of widening and contracting in-place conversions. |
@sviswa7 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 62 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@sviswa7 Since your change was applied there have been 81 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9de5d09. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove partially implemented in-place conversion vector operators from Vector API:
ofNarrowing, ofWidening, INPLACE_XXX
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1305/head:pull/1305
$ git checkout pull/1305