New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256670: Zero: enable compressed oops support back #1320
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me. I can't think of why zero disabled compressed oops.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This patch survived more rounds of testing, including quite aggressive Shenandoah tests, so it should be good. /integrate |
@shipilev Since your change was applied there have been 49 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 037e49c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
UseCompressedOops was disabled for C++ interpreter by JDK-6909153, and it eventually morphed to disabled UseCompressedOops for all Zero configurations. I see nothing that actually prevents Zero from using compressed oops: all local/stack operands are always unpacked (like they are in non-interpreted modes), all heap accesses are calling into utility methods that handle compressed oops, there are no raw accesses to oops anywhere.
Additional testing:
hotspot_gc_shenandoah
with Zero, now passing compressed oops testsProgress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1320/head:pull/1320
$ git checkout pull/1320