JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) #13689

JimLaskey · 2023-04-27T12:38:11Z

Add flexible main methods and anonymous main classes to the Java language.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Change requires CSR request JDK-8308916 to be approved
Commit message must refer to an issue
Change requires CSR request JDK-8306113 to be approved
Change requires CSR request JDK-8308831 to be approved

Issues

JDK-8306112: Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview)
JDK-8308613: javax.lang.model updates for JEP 445 (preview)
JDK-8308913: Update core reflection for JEP 445 (preview)
JDK-8308916: Update core reflection for JEP 445 (preview) (CSR)
JDK-8308831: javax.lang.model updates for JEP 445 (preview) (CSR)
JDK-8306113: Implementation for JEP 445: Unnamed Classes and Instance Main Methods (Preview) (CSR)

Reviewers

Maurizio Cimadamore (@mcimadamore - Reviewer) ⚠️ Review applies to ff7cd4c7
Vicente Romero (@vicente-romero-oracle - Reviewer) ⚠️ Review applies to b91e75aa
Joe Darcy (@jddarcy - Reviewer) ⚠️ Review applies to 55b6be5b

Contributors

Maurizio Cimadamore <mcimadamore@openjdk.org>
Joe Darcy <darcy@openjdk.org>
Jan Lahoda <jlahoda@openjdk.org>
Jim Laskey <jlaskey@openjdk.org>
Adam Sotona <asotona@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13689/head:pull/13689
$ git checkout pull/13689

Update a local copy of the PR:
$ git checkout pull/13689
$ git pull https://git.openjdk.org/jdk.git pull/13689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13689

View PR using the GUI difftool:
$ git pr show -t 13689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13689.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-04-27T12:39:08Z

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-04-27T12:42:25Z

@JimLaskey The following labels will be automatically applied to this pull request:

build
compiler
core-libs
hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-04-27T13:04:23Z

Webrevs

src/java.base/share/native/libjli/java.c

src/java.base/share/classes/sun/launcher/LauncherHelper.java

src/java.base/share/classes/sun/launcher/resources/launcher.properties

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/VirtualParser.java

jddarcy · 2023-04-27T15:55:37Z

I assume future iterations of the PR will include handling and tests for the main class attribute of jar files.

JimLaskey · 2023-06-05T15:36:26Z

/help contributor

openjdk · 2023-06-05T15:36:59Z

@JimLaskey Available commands:

backport - create a backport
cc - add or remove an additional classification label
clean - Mark the backport pull request as a clean backport
contributor - adds or removes additional contributors for a PR
covered - used when employer has signed the OCA
csr - require a compatibility and specification request (CSR) for this pull request
help - shows this text
integrate - performs integration of the changes in the PR
issue - edit the list of issues that this PR solves
jep - require a JDK Enhancement Proposal (JEP) for this pull request
label - add or remove an additional classification label
open - Set the pull request state to "open"
reviewer - manage additional reviewers for a PR
reviewers - set the number of additional required reviewers for this PR
signed - used after signing the OCA
solves - edit the list of issues that this PR solves
sponsor - performs integration of a PR that is authored by a non-committer
summary - updates the summary in the commit message
test - used to run tests

JimLaskey · 2023-06-05T15:41:02Z

/contributor add lahodaj

JimLaskey · 2023-06-05T15:41:32Z

/contributor add jddarcy

JimLaskey · 2023-06-05T15:42:01Z

/contributor add mcimadamore

openjdk · 2023-06-05T15:42:53Z

@JimLaskey lahodaj was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

openjdk · 2023-06-05T15:43:22Z

@JimLaskey jddarcy was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

openjdk · 2023-06-05T15:43:47Z

@JimLaskey
Contributor Maurizio Cimadamore <mcimadamore@openjdk.org> successfully added.

JimLaskey · 2023-06-05T16:10:18Z

/contributor add darcy

JimLaskey · 2023-06-05T16:11:26Z

/contributor add lahoda

openjdk · 2023-06-05T16:11:31Z

@JimLaskey
Contributor Joe Darcy <darcy@openjdk.org> successfully added.

openjdk · 2023-06-05T16:13:29Z

@JimLaskey lahoda was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

JimLaskey · 2023-06-05T17:09:51Z

/contributor add jlahoda

openjdk · 2023-06-05T17:11:19Z

@JimLaskey
Contributor Jan Lahoda <jlahoda@openjdk.org> successfully added.

JimLaskey · 2023-06-05T17:49:59Z

/contributor add jlaskey

openjdk · 2023-06-05T17:51:17Z

@JimLaskey
Contributor Jim Laskey <jlaskey@openjdk.org> successfully added.

JimLaskey · 2023-06-05T18:08:23Z

/contributor add asotona

openjdk · 2023-06-05T18:26:58Z

@JimLaskey
Contributor Adam Sotona <asotona@openjdk.org> successfully added.

JimLaskey · 2023-06-05T18:44:24Z

/integrate

openjdk · 2023-06-05T18:45:57Z

Going to push as commit 98b53c0.
Since your change was applied there have been 4 commits pushed to the master branch:

e970ddb: 8309170: CDS archive heap is always relocated for larger heap
4b8922f: 8308842: Consolidate exceptions thrown from Class-File API
2b38343: 8309416: Misstatement in semantics of methods in javax.lang.model.ElementFilter
73352b6: 8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction

Your commit was automatically rebased without conflicts.

openjdk · 2023-06-05T18:46:07Z

@JimLaskey Pushed as commit 98b53c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JimLaskey added 12 commits April 21, 2023 15:31

JEP 445

bbd1de8

Merge branch 'master' into 8306112

8545dcc

Revised main method lookup

d5ebe61

remnant import

a7bca07

Clean up

891d00b

Merge branch 'master' into 8306112

8c023f5

Update TestJavacTaskScanner.java

db12c9a

Clean up testing

44af61d

Update VM.java

ef56b9e

Corrections

3f174fc

Missing exception

a89cb96

Clean up isPreview

cfe08f3

openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 27, 2023

openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Apr 27, 2023

PreviewFeatures.isEnabled()

a55af76

AlanBateman reviewed Apr 27, 2023

View reviewed changes

src/java.base/share/native/libjli/java.c Show resolved Hide resolved

AlanBateman reviewed Apr 27, 2023

View reviewed changes

src/java.base/share/classes/sun/launcher/LauncherHelper.java Outdated Show resolved Hide resolved

AlanBateman reviewed Apr 27, 2023

View reviewed changes

src/java.base/share/classes/sun/launcher/resources/launcher.properties Outdated Show resolved Hide resolved

mcimadamore reviewed Apr 27, 2023

View reviewed changes

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java Outdated Show resolved Hide resolved

mcimadamore reviewed Apr 27, 2023

View reviewed changes

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java Outdated Show resolved Hide resolved

mcimadamore reviewed Apr 27, 2023

View reviewed changes

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/VirtualParser.java Outdated Show resolved Hide resolved

Merge branch 'master' into 8306112

53a5321

Merge branch 'master' into 8306112

94d1eef

JimLaskey added 2 commits June 5, 2023 13:00

Final clean up

3bbdb8f

Merge branch 'master' into 8306112

663ca88

-Xprint unnamed classes to use e.getSimpleName()

d0fdf69

openjdk bot added the integrated Pull request has been integrated label Jun 5, 2023

openjdk bot closed this Jun 5, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2023

wesleyegberto mentioned this pull request Jun 8, 2023

java 21 features using which JDK download? wesleyegberto/java-new-features#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) #13689

JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) #13689

JimLaskey commented Apr 27, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 27, 2023

openjdk bot commented Apr 27, 2023

mlbridge bot commented Apr 27, 2023 •

edited

Loading

jddarcy commented Apr 27, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) #13689

JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) #13689

Conversation

JimLaskey commented Apr 27, 2023 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Contributors

Reviewing

Webrev

bridgekeeper bot commented Apr 27, 2023

openjdk bot commented Apr 27, 2023

mlbridge bot commented Apr 27, 2023 • edited Loading

Webrevs

jddarcy commented Apr 27, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

openjdk bot commented Jun 5, 2023

JimLaskey commented Apr 27, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 27, 2023 •

edited

Loading