Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction #14266

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Jun 1, 2023

This change resolves the issue that drag and drop from a Java application to a native Wayland application (such as gedit) is not possible on Linux.

Our code it quite picky for the drop target, and requires it to be a top level window with the WM_STATE property set, whereas the XWayland server provides dummy windows without this property.
So now we make an exclusion for this case.

After the fix it successfully passes previously failed related manual jtreg/conformance tests on Wayland.
Other tests are also passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14266/head:pull/14266
$ git checkout pull/14266

Update a local copy of the PR:
$ git checkout pull/14266
$ git pull https://git.openjdk.org/jdk.git pull/14266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14266

View PR using the GUI difftool:
$ git pr show -t 14266

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14266.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2023
@openjdk
Copy link

openjdk bot commented Jun 1, 2023

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 1, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 1, 2023

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction

Reviewed-by: prr, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

  • 6d511f1: 8309129: AArch64: guarantee(T != T2S) failed: "incorrect arrangement" after JDK-8307795
  • 9be5769: 8291966: SwitchBootstrap.typeSwitch could be faster
  • db0857d: 8306578: Report error if no label given in @see and {@link} when no default is available
  • 8c9d21e: 8296920: Regression Test DialogOrient.java fails on MacOS
  • ac41c03: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates
  • 11fb5b2: 8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong values with Graal
  • a02d800: 8309405: RISC-V: is_deopt may produce unaligned memory read
  • 3fa776d: 8302673: [SuperWord] MaxReduction and MinReduction should vectorize for int
  • 22a9a86: 8309268: C2: "assert(in_bb(n)) failed: must be" after JDK-8306302
  • b6c9232: 8305225: A service broken error despite annotation processor generating it if directives listed
  • ... and 35 more: https://git.openjdk.org/jdk/compare/050425b141d710659928020dd89f94ed46c056a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2023
@azvegint
Copy link
Member Author

azvegint commented Jun 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2023

Going to push as commit 73352b6.
Since your change was applied there have been 47 commits pushed to the master branch:

  • 5cd8af7: 8308726: RISC-V: avoid unnecessary slli in the vectorized arraycopy stubs for bytes
  • 80232b7: 8308969: make test-prebuilt doesn't return the correct exit code
  • 6d511f1: 8309129: AArch64: guarantee(T != T2S) failed: "incorrect arrangement" after JDK-8307795
  • 9be5769: 8291966: SwitchBootstrap.typeSwitch could be faster
  • db0857d: 8306578: Report error if no label given in @see and {@link} when no default is available
  • 8c9d21e: 8296920: Regression Test DialogOrient.java fails on MacOS
  • ac41c03: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates
  • 11fb5b2: 8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong values with Graal
  • a02d800: 8309405: RISC-V: is_deopt may produce unaligned memory read
  • 3fa776d: 8302673: [SuperWord] MaxReduction and MinReduction should vectorize for int
  • ... and 37 more: https://git.openjdk.org/jdk/compare/050425b141d710659928020dd89f94ed46c056a6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2023
@openjdk openjdk bot closed this Jun 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2023
@openjdk
Copy link

openjdk bot commented Jun 5, 2023

@azvegint Pushed as commit 73352b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants