New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction #14266
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
Webrevs
|
src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java
Outdated
Show resolved
Hide resolved
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 45 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java
Outdated
Show resolved
Hide resolved
src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java
Outdated
Show resolved
Hide resolved
src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java
Outdated
Show resolved
Hide resolved
src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java
Outdated
Show resolved
Hide resolved
src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java
Outdated
Show resolved
Hide resolved
src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java
Outdated
Show resolved
Hide resolved
/integrate |
Going to push as commit 73352b6.
Your commit was automatically rebased without conflicts. |
This change resolves the issue that drag and drop from a Java application to a native Wayland application (such as gedit) is not possible on Linux.
Our code it quite picky for the drop target, and requires it to be a top level window with the WM_STATE property set, whereas the XWayland server provides dummy windows without this property.
So now we make an exclusion for this case.
After the fix it successfully passes previously failed related manual jtreg/conformance tests on Wayland.
Other tests are also passed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14266/head:pull/14266
$ git checkout pull/14266
Update a local copy of the PR:
$ git checkout pull/14266
$ git pull https://git.openjdk.org/jdk.git pull/14266/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14266
View PR using the GUI difftool:
$ git pr show -t 14266
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14266.diff
Webrev
Link to Webrev Comment