Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8309595 Allow javadoc to process unnamed classes #14356

Closed
wants to merge 2 commits into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Jun 7, 2023

Unnamed classes are rejected by javadoc because they are synthetic.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309595: Allow javadoc to process unnamed classes (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14356/head:pull/14356
$ git checkout pull/14356

Update a local copy of the PR:
$ git checkout pull/14356
$ git pull https://git.openjdk.org/jdk.git pull/14356/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14356

View PR using the GUI difftool:
$ git pr show -t 14356

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14356.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2023

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@JimLaskey The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Jun 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2023

Webrevs

Copy link
Member

@hns hns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309595: Allow javadoc to process unnamed classes

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 92beb85: 8309474: [IR Framework] Wrong @ForceCompile link in README
  • 6402004: 8256302: releasing oopStorage when deflating allows for faster deleting
  • 02bce0b: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI
  • 4ffc8cc: 8309574: Improve core reflection tests for JEP 445
  • e3f3ac0: 8309420: com/sun/jdi/StepTest.java fails with virtual thread wrapper
  • c38abbf: 8309510: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java no longer needs to override startUp() method
  • c24b0ba: 8309503: Improve javax.lang.model tests for JEP 445
  • a54f4d4: 8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory
  • 33bb64f: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
  • 5b147eb: 8308288: Fix xlc17 clang warnings and build errors in hotspot
  • ... and 11 more: https://git.openjdk.org/jdk/compare/a6726b66dbb3ffa7b2245bb9c27c4bc87148f39c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2023
@JimLaskey
Copy link
Member Author

/backport

@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 8, 2023

@JimLaskey Usage: /backport [disable] <repository> [<branch>]

@openjdk
Copy link

openjdk bot commented Jun 8, 2023

Going to push as commit 0be3905.
Since your change was applied there have been 36 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 8, 2023
@openjdk openjdk bot closed this Jun 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2023
@openjdk
Copy link

openjdk bot commented Jun 8, 2023

@JimLaskey Pushed as commit 0be3905.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JimLaskey
Copy link
Member Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jun 8, 2023

@JimLaskey the backport was successfully created on the branch JimLaskey-backport-0be39054 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 0be39054 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 8 Jun 2023 and was reviewed by Hannes Wallnöfer.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-0be39054:JimLaskey-backport-0be39054
$ git checkout JimLaskey-backport-0be39054
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-0be39054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants