-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash #14620
Conversation
…th hyphen, not dash
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correcting the description of the delimiter seems like the best solution.
As a doc-only change it would also be appropriate for JDK 21 also. |
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 68 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ec45bd6.
Your commit was automatically rebased without conflicts. |
Replacing the ambiguous
dash
withhyphen-minus
for more clarity. There are other locations thanISO_LOCAL_DATE
that have the same description. Those are corrected too.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14620/head:pull/14620
$ git checkout pull/14620
Update a local copy of the PR:
$ git checkout pull/14620
$ git pull https://git.openjdk.org/jdk.git pull/14620/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14620
View PR using the GUI difftool:
$ git pr show -t 14620
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14620.diff
Webrev
Link to Webrev Comment