New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255001: Move G1PeriodicGCTask to its own file #1471
Conversation
👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into |
#include "gc/g1/g1ServiceThread.hpp" | ||
#include "utilities/globalDefinitions.hpp" | ||
#include "utilities/ticks.hpp" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the g1ServiceThread include seems to be required here. The others can be moved to the cpp file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, move the #include "utilities/globalDefinitions.hpp"
to the cpp file, tick.hpp
was not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@kstefanj this pull request can not be integrated into git checkout 8255001-move-periodic-gc-task
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@kstefanj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@kstefanj Since your change was applied there have been 29 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 02ba519. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
After making the service thread task based it is now possible to move the tasks out of
g1ServiceThread.cpp
. The periodic task is moved to its own files and the initialization and registration with the service thread is done while initializingG1CollectedHeap
.No functionality is changed for the task, but it has been split up into a header and a source file.
Testing
tier 1-2 + manual testing setting
G1PeriodicGCInterval
throughjcmd
.Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1471/head:pull/1471
$ git checkout pull/1471