8311541: JavaThread::print_jni_stack doesn't support native stacks on all platforms

[dholmes-ora]

JDK-8295974 modified print_jni_stack to print the native stack when there are no Java frames. To do that it used VMError::print_native_stack, however that function is only for platforms that support stack-walking by following frames, on other platforms (i.e. Windows and AIX) we need to use os::platform_print_native_stack.

I'm not trying to consolidate the different versions of the stack printing code in this PR so that it is more easily backported to where JDK-8295974 was.

The test has been updated to work on Windows (taking advantage of two other recent enhancements - see JBS for details).

Testing:

• tiers 1-3 (sanity)
• TestNativeStack regression test

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311541: JavaThread::print_jni_stack doesn't support native stacks on all platforms (Enhancement - P3)

Reviewers

• Patricio Chilano Mateo (@pchilano - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14862/head:pull/14862
$ git checkout pull/14862

Update a local copy of the PR:
$ git checkout pull/14862
$ git pull https://git.openjdk.org/jdk.git pull/14862/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14862

View PR using the GUI difftool:
$ git pr show -t 14862

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14862.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following labels will be automatically applied to this pull request:

• build
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3b51090a)

[dholmes-ora]

Ping!

[pchilano]

Looks good to me.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311541: JavaThread::print_jni_stack doesn't support native stacks on all platforms

Reviewed-by: pchilanomate, shade, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• b4dce0d: 8310814: Clarify the targetName parameter of Lookup::findClass
• 9905f75: 8311040: JFR: RecordedThread::getOSThreadId() should return -1 if thread is virtual
• 1dfb0fb: 8311188: Simplify and modernize equals and hashCode in java.text
• 1fc726a: 8312163: Crash in dominance check when compiling unnamed patterns
• b20dc1e: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
• 4b9ec82: 8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest
• 8ec136e: 8312072: Deprecate for removal the -Xnoagent option
• fbe51e3: 8312127: FileDescriptor.sync should temporarily increase parallelism
• 201e3bc: 8291065: Creating a VarHandle for a static field triggers class initialization
• a53345a: 8287061: Support for rematerializing scalar replaced objects participating in allocation merges
• ... and 43 more: https://git.openjdk.org/jdk/compare/11a5115caf179a1bbed5311e12ed3851e026c5c5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Looks reasonable. Is _WIN32 defined for Windows 64 as well? Consider a nit, if you have any other changes in the pipe for this PR. Ignore otherwise.

[tstuefe]

Good. Small nit inline.

Cheers, Thomas

[dholmes-ora]

Is _WIN32 defined for Windows 64 as well?

Yes.

[dholmes-ora]

Thanks for the reviews @tstuefe and @shipilev !

[dholmes-ora]

/integrate

[openjdk]

Going to push as commit c2f421b.
Since your change was applied there have been 68 commits pushed to the master branch:

• e31df3a: 6211126: ICC_ColorSpace.toCIEXYZ(float[]): NPE is not specified
• 7d9f5af: 6211202: ColorSpace.getInstance(int): IAE is not specified
• 28c4d19: 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
• 5c4623b: 8308682: Enhance AES performance
• cb5f1b7: 8303376: Better launching of JDI
• 925138a: 8296565: Enhanced archival support
• 889c663: 8305312: Enhanced path handling
• be70bc1: 8294323: Improve Shared Class Data
• ecd0bc1: 8300596: Enhance Jar Signature validation
• fff7e1a: 8302483: Enhance ZIP performance
• ... and 58 more: https://git.openjdk.org/jdk/compare/11a5115caf179a1bbed5311e12ed3851e026c5c5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit c2f421b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

Oops! Thanks for the review @pchilano - sorry I initially missed seeing it.