JDK-8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction

[tstuefe]

The test causes intermittent rare errors, so far only seen on Oracle 7.9 with glibc 2.17.

This PR disables, for automated testing, the RSS evaluation part of the test. It retains the mechanical part (testing whether trims happen at all, in the expected number). The stricter variant of the test is kept as manual tests (usable with jtreg without -a).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14984/head:pull/14984
$ git checkout pull/14984

Update a local copy of the PR:
$ git checkout pull/14984
$ git pull https://git.openjdk.org/jdk.git pull/14984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14984

View PR using the GUI difftool:
$ git pr show -t 14984

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14984.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (67528a54)
• 00: Full (28537f24)

[dholmes-ora]

Seems reasonable. Not 100% sure about the extra logging ... one query in relation to that.

Thanks.

[dholmes-ora]

What about the content of /etc/ld.so.preload? (We show that in hs_err file.)

[tstuefe]

Oh, you are right. I'll check how much more lines that would add; I don't want to bloat the complexity too much.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction

Reviewed-by: dholmes, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 271417a: 8312579: [JVMCI] JVMCI support for virtual Vector API objects
• 44576a7: 8312466: /bin/nm usage in AIX makes needs -X64 flag
• 86821a7: 8312235: [JVMCI] ConstantPool should not force eager resolution
• 7cbab1f: 8312218: Print additional debug information when hitting assert(in_hash)
• 01e135c: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
• b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
• 36d578c: 8311653: Modify -XshowSettings launcher behavior
• a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
• 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
• 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
• ... and 35 more: https://git.openjdk.org/jdk/compare/0328886450a4978f1edbe06a59d2ab8f733d19a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

@dholmes-ora : I removed parts of the logging. I went down a small rabbit hole about extending to /etc/ld.preload, about unifying that code with existing ld_preload printing, about security concerns (maybe we should obfuscate the values when logging), then I gave up and just removed it, since it does not directly relate to the patch at hand.

[dholmes-ora]

Ok

[shipilev]

Looks fine.

[tstuefe]

Thanks @dholmes-ora and @shipilev, and thanks for running this through Oracles CI!

/integrate

[openjdk]

Going to push as commit ad34be1.
Since your change was applied there have been 68 commits pushed to the master branch:

• d6245b6: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
• 402cb6a: 8312201: Clean up common behavior in "page writers" and "member writers"
• 23755f9: 8312411: MessageFormat.formatToCharacterIterator() can be improved
• e2cb0bc: 8313204: Inconsistent order of sections in generated class documentation
• 4ae75ca: 8313253: Rename methods in javadoc Comparators class
• e897041: 8312262: Klass::array_klass() should return ArrayKlass pointer
• a9a3463: 8312416: Tests in Locale should have more descriptive names
• d9559f9: 8312612: handle WideCharToMultiByte return values
• 34173ff: 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout
• 47c4b99: 8312121: Fix -Wconversion warnings in tribool.hpp
• ... and 58 more: https://git.openjdk.org/jdk/compare/0328886450a4978f1edbe06a59d2ab8f733d19a9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit ad34be1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.