Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8313602: increase timeout for jdk/classfile/CorpusTest.java #15122

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 2, 2023

On some slow machines (e.g. Alpine) we see sporadic timeouts of the jdk/classfile/CorpusTest.java test, even with an increased standard timeout factor.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313602: increase timeout for jdk/classfile/CorpusTest.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15122/head:pull/15122
$ git checkout pull/15122

Update a local copy of the PR:
$ git checkout pull/15122
$ git pull https://git.openjdk.org/jdk.git pull/15122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15122

View PR using the GUI difftool:
$ git pr show -t 15122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15122.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@MBaesken To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313602: increase timeout for jdk/classfile/CorpusTest.java

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 2, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Aug 2, 2023

Hi Christoph, thanks for the review !
Can we consider this trivial ?
Is there a second review needed ?

@MBaesken
Copy link
Member Author

MBaesken commented Aug 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

Going to push as commit bdac348.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2023
@openjdk openjdk bot closed this Aug 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@MBaesken Pushed as commit bdac348.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants