-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313707: GHA: Bootstrap sysroots with --variant=minbase #15140
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me (Not a build expert). Thanks.
Thanks! I am integrating to unbreak GHA. /integrate |
Going to push as commit 29f1d8e.
Your commit was automatically rebased without conflicts. |
We don't need the fully bootable Debian installation to build against. Therefore, we can bootstrap with
--variant=minbase
. The sysroots are about 5..10% smaller then.This would also make our builds more immune to issues like JDK-8313701. Note how RISC-V GHAs are fixed with this PR by dodging the systemd dependency failure.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15140/head:pull/15140
$ git checkout pull/15140
Update a local copy of the PR:
$ git checkout pull/15140
$ git pull https://git.openjdk.org/jdk.git pull/15140/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15140
View PR using the GUI difftool:
$ git pr show -t 15140
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15140.diff
Webrev
Link to Webrev Comment