Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK-8294090 : Aligns the CSS <rgb()> and <rgba()> function behaviours #15262

Closed
wants to merge 10 commits into from
Closed

JDK-8294090 : Aligns the CSS <rgb()> and <rgba()> function behaviours #15262

wants to merge 10 commits into from
+360 −48

Conversation

scientificware
Copy link
Contributor

@scientificware scientificware commented Aug 13, 2023 •
edited by openjdk bot
Loading

This is referenced in Java Bug Database as

This is tracked in JBS as

Aligns the <rgb()> and <rgba()> function behaviours in CSS.java, as described in :
CSS Color Module Level 4
W3C Candidate Recommendation Snapshot, 5 July 2022
4.1 The <Color> syntax
6.1. The RGB functions: rgb() and rgba()

Designed from : ScientificWare JDK-8294090 : Aligns the CSS <rgb()> and <rgba()> function behaviours

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294090: Aligns the CSS <rgb()> and <rgba()> function behaviours (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15262/head:pull/15262
$ git checkout pull/15262

Update a local copy of the PR:
$ git checkout pull/15262
$ git pull https://git.openjdk.org/jdk.git pull/15262/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15262

View PR using the GUI difftool:
$ git pr show -t 15262

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15262.diff

Webrev

Link to Webrev Comment

@scientificware
Amélioration de la prise en charge des fonctions rgb et rgba concerna…
acea1c6 
…nt les couleurs.
@scientificware
Merge master
7277d35 
# Conflicts:
#	src/java.desktop/share/classes/javax/swing/text/html/CSS.java
@scientificware
8294090 :
b2eae3c 
CSS.java :
  - Adds links to CSS-COLOR-4 and CSS-VALUE-4 specifications.
  - Update PARSE RGB method comments.
  - Adds base-ten exponent support.

RGBandRGBAalignmentBehaviours.java :
  - Adds a set of tests for RGB functions.
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2023

👋 Welcome back scientificware! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2023

@scientificware The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 13, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 13, 2023
This was referenced Aug 13, 2023
Open
Open
Open
Open
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2023 •
edited
Loading

Webrevs

@scientificware scientificware mentioned this pull request Aug 12, 2022
Open
@scientificware scientificware mentioned this pull request Aug 17, 2023
Closed
4 tasks
@scientificware
Merge master
86e079d
@scientificware
CSS.java :
4686ead 
- Adds a comment about consecutive non space separators.
- Adds e uppercase test.

RGBandRGBAalignmentBehaviours.java :
- Adds test cases with uppercase e.
@scientificware
RGBandRGBAalignmentBehaviours.java :
f34d70a 
- Change list name.
@scientificware
Merge master
440b7dd
@scientificware
Merge branch 'scientificware-patch-004-CSS-aligns_rgb_and_rgba_functi…
d853f95 
…on_behaviours' of github.com:scientificware/jdk into scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours
@openjdk
Copy link

openjdk bot commented Aug 20, 2023

⚠️ @scientificware This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

@scientificware This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@prrace
Copy link
Contributor

prrace commented Oct 7, 2023

Read the comment in #9825.
This PR needs to be merged into that PR and this PR withdrawn.
Bugs should be closed as dups.

@prrace
Copy link
Contributor

prrace commented Oct 7, 2023

I don't intend to do a detailed review of this PR until the content is merged into the other one.

@scientificware
Copy link
Contributor Author

I close the PR JDK-8294090 and I'll merge its content in #9825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prrace prrace prrace requested changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Milestone
No milestone
2 participants
@scientificware @prrace