Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option #15340

Closed
wants to merge 1 commit into from

Conversation

vpa1977
Copy link
Contributor

@vpa1977 vpa1977 commented Aug 18, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15340/head:pull/15340
$ git checkout pull/15340

Update a local copy of the PR:
$ git checkout pull/15340
$ git pull https://git.openjdk.org/jdk.git pull/15340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15340

View PR using the GUI difftool:
$ git pr show -t 15340

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15340.diff

Webrev

Link to Webrev Comment

@vpa1977 vpa1977 marked this pull request as ready for review August 18, 2023 05:58
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2023

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@vpa1977 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org rfr Pull request is ready for review labels Aug 18, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • ed0f75f: 8313290: Misleading exception message from STS.Subtask::get when task forked after shutdown
  • febc34d: 8314610: hotspot can't compile with the latest of gtest because of
  • 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408
  • 395fc78: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • f481477: 8314320: Mark runtime/CommandLine/ tests as flagless
  • fbe28ee: 8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed
  • 50a2ce0: 8310815: Clarify the name of the main class, services and provider classes in module descriptor
  • aecbb1b: 8314448: Coordinate DocLint and JavaDoc to report on unknown tags
  • bcba5e9: 8313419: Template interpreter produces no safepoint check for return bytecodes
  • c36e009: 8308984: Relativize last_sp (and top_frame_sp) in interpreter frames
  • ... and 6 more: https://git.openjdk.org/jdk/compare/0299364d85a66c35e616148cbbde314b7d4fb05a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2023
@vpa1977
Copy link
Contributor Author

vpa1977 commented Aug 20, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 20, 2023
@openjdk
Copy link

openjdk bot commented Aug 20, 2023

@vpa1977
Your change (at version 221edc8) is now ready to be sponsored by a Committer.

@erikj79
Copy link
Member

erikj79 commented Aug 24, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

Going to push as commit e36620d.
Since your change was applied there have been 66 commits pushed to the master branch:

  • 97b94cb: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 75e19e0: 8314819: [JVMCI] HotSpotJVMCIRuntime.lookupType throws unexpected ClassNotFoundException
  • c418933: 8313530: VM build without C2 fails after JDK-8312579
  • de0e46c: 8303815: Improve Metaspace test speed
  • 3699666: 8313319: [linux] mmap should use MAP_FIXED_NOREPLACE if available
  • 3285a1e: 8314555: Build with mawk fails on Windows
  • 4a50e87: 8303852: current_stack_region() gets called twice unnecessarily
  • c077be4: 8314694: Separate checked_cast from globalDefinitions.hpp
  • 68815d5: 8314734: Remove unused field TypeVariableImpl.EMPTY_ANNOTATION_ARRAY
  • 57a322d: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
  • ... and 56 more: https://git.openjdk.org/jdk/compare/0299364d85a66c35e616148cbbde314b7d4fb05a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2023
@openjdk openjdk bot closed this Aug 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@erikj79 @vpa1977 Pushed as commit e36620d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants