JDK-8314517: some tests fail in case ipv6 is disabled on the machine #15341

MBaesken · 2023-08-18T06:53:19Z

Some jtreg tests fail with ipv6 disabled on the machine, this should be improved in the tests (e.g. by using IPSupport.hasIPv6() ).

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8314517: some tests fail in case ipv6 is disabled on the machine (Bug - P4)

Reviewers

Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to 2d5986e0
Lutz Schmidt (@RealLucy - Reviewer) ⚠️ Review applies to 2d5986e0
Jaikiran Pai (@jaikiran - Reviewer) ⚠️ Review applies to 2d5986e0
Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15341/head:pull/15341
$ git checkout pull/15341

Update a local copy of the PR:
$ git checkout pull/15341
$ git pull https://git.openjdk.org/jdk.git pull/15341/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15341

View PR using the GUI difftool:
$ git pr show -t 15341

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15341.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-08-18T06:54:46Z

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-08-18T06:57:00Z

@MBaesken The following label will be automatically applied to this pull request:

net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-08-18T07:00:54Z

Webrevs

01: Full - Incremental (28205984)
00: Full (2d5986e0)

TheRealMDoerr

Looks reasonable.

openjdk · 2023-08-18T08:25:37Z

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314517: some tests fail in case ipv6 is disabled on the machine

Reviewed-by: mdoerr, lucy, jpai, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

742e319: 8314157: G1: "yielded" is not initialized on some paths after JDK-8140326
1cee3b9: 8313262: C2: Sinking node may cause required cast to be dropped
f8203cb: 8313626: C2 crash due to unexpected exception control flow
2be469f: 8314743: Use of uninitialized local in SR_initialize after JDK-8314114
571c435: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
d1de3d0: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
a0d0f21: 8314752: Use google test string comparison macros
7e843c2: 8284772: GHA: Use GCC Major Version Dependencies Only
ba6cdbe: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
... and 50 more: https://git.openjdk.org/jdk/compare/c634bdf9d917c96c38efe826239eab7900c33e74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

RealLucy

LGTM.
Testing IPV6 only if it is available for sure makes sense.

jaikiran · 2023-08-21T07:35:19Z

test/jdk/java/net/InetAddress/HostsFileOrderingTest.java

-            System.err.printf("Expected addresses:%n%s%n", Arrays.deepToString(expectedAddresses));
-            System.err.printf("Resolved addresses:%n%s%n", Arrays.deepToString(resolvedAddresses));
-            Assert.fail("Wrong host resolution result is returned");
+        if (IPSupport.hasIPv6()) {


Hello Matthias, unlike changes to some other tests, this skips the entire test method if there's no IPv6 support. So perhaps add a System.out message that this test is skipped? I checked if testng has assumeTrue kind of API like junit, but I couldn't find any, so just returning by printing a System.out message might be enough.

Some of the test runs should work whether the machine has IPv6 or not. Maybe this test should be more selective with respect to when the test should be skipped. For instance at line 47-48:

* @run testng/othervm -Djdk.net.hosts.file=TestHostsFile.txt * -Djava.net.preferIPv4Stack=true -Djava.net.preferIPv6Addresses=false HostsFileOrderingTest

well - that should work - and only return IPv4 addresses.

On second thought - I suspect it's getExpectedAddressesArray() that should be fixed to take into account IPSupport.hasIPv6() instead of doing it here.

jaikiran

I've added a trivial review comment about one of the test method changes. Other than that, these changes look OK to me.

MBaesken · 2023-08-22T07:51:37Z

Hi Daniel and Jaikiran, I adjusted the HostsFileOrderingTest.java a bit.

dfuch · 2023-08-22T13:43:08Z

Hi Matthias, this looks much better. Let me give it whirl on the CI to double check there's not unexpected side effects.

MBaesken · 2023-08-22T14:04:17Z

Hi Matthias, this looks much better. Let me give it whirl on the CI to double check there's not unexpected side effects.

Sounds good, thanks !

MBaesken · 2023-08-23T07:47:55Z

Hi Matthias, this looks much better. Let me give it whirl on the CI to double check there's not unexpected side effects.

The latest version worked nicely in our tests; any issues seen in your CI ?

dfuch

LGTM

MBaesken · 2023-08-23T10:43:37Z

Thanks for the reviews!

/integrate

openjdk · 2023-08-23T10:44:42Z

Going to push as commit 703817d.
Since your change was applied there have been 60 commits pushed to the master branch:

742e319: 8314157: G1: "yielded" is not initialized on some paths after JDK-8140326
1cee3b9: 8313262: C2: Sinking node may cause required cast to be dropped
f8203cb: 8313626: C2 crash due to unexpected exception control flow
2be469f: 8314743: Use of uninitialized local in SR_initialize after JDK-8314114
571c435: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
d1de3d0: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
a0d0f21: 8314752: Use google test string comparison macros
7e843c2: 8284772: GHA: Use GCC Major Version Dependencies Only
ba6cdbe: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
... and 50 more: https://git.openjdk.org/jdk/compare/c634bdf9d917c96c38efe826239eab7900c33e74...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-08-23T10:44:51Z

@MBaesken Pushed as commit 703817d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8314517

2d5986e

openjdk bot added the rfr Pull request is ready for review label Aug 18, 2023

openjdk bot added the net net-dev@openjdk.org label Aug 18, 2023

TheRealMDoerr approved these changes Aug 18, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2023

RealLucy approved these changes Aug 18, 2023

View reviewed changes

jaikiran reviewed Aug 21, 2023

View reviewed changes

jaikiran approved these changes Aug 21, 2023

View reviewed changes

adjust HostsFileOrderingTest

2820598

dfuch approved these changes Aug 23, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Aug 23, 2023

openjdk bot closed this Aug 23, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8314517: some tests fail in case ipv6 is disabled on the machine #15341

JDK-8314517: some tests fail in case ipv6 is disabled on the machine #15341

MBaesken commented Aug 18, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Aug 18, 2023

openjdk bot commented Aug 18, 2023

mlbridge bot commented Aug 18, 2023 •

edited

Loading

TheRealMDoerr left a comment

openjdk bot commented Aug 18, 2023 •

edited

Loading

RealLucy left a comment

jaikiran Aug 21, 2023

dfuch Aug 21, 2023

jaikiran left a comment

MBaesken commented Aug 22, 2023

dfuch commented Aug 22, 2023

MBaesken commented Aug 22, 2023

MBaesken commented Aug 23, 2023

dfuch left a comment

MBaesken commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

JDK-8314517: some tests fail in case ipv6 is disabled on the machine #15341

JDK-8314517: some tests fail in case ipv6 is disabled on the machine #15341

Conversation

MBaesken commented Aug 18, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Aug 18, 2023

openjdk bot commented Aug 18, 2023

mlbridge bot commented Aug 18, 2023 • edited Loading

Webrevs

TheRealMDoerr left a comment

Choose a reason for hiding this comment

openjdk bot commented Aug 18, 2023 • edited Loading

RealLucy left a comment

Choose a reason for hiding this comment

jaikiran Aug 21, 2023

Choose a reason for hiding this comment

dfuch Aug 21, 2023

Choose a reason for hiding this comment

jaikiran left a comment

Choose a reason for hiding this comment

MBaesken commented Aug 22, 2023

dfuch commented Aug 22, 2023

MBaesken commented Aug 22, 2023

MBaesken commented Aug 23, 2023

dfuch left a comment

Choose a reason for hiding this comment

MBaesken commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

MBaesken commented Aug 18, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 18, 2023 •

edited

Loading

openjdk bot commented Aug 18, 2023 •

edited

Loading